Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for LazyShadowTreeRevisionConsistencyManager and fix bugs #44337

Closed
wants to merge 1 commit into from
Closed

Add test for LazyShadowTreeRevisionConsistencyManager and fix bugs #44337

wants to merge 1 commit into from

Commits on Apr 30, 2024

  1. Add test for LazyShadowTreeRevisionConsistencyManager and fix bugs 

    Summary:
Changelog: [internal]

`LazyShadowTreeRevisionConsistencyManager` wasn't correctly updating the locked revision, because `emplace` is a no-op if there's already a value for the key in the `unordered_map`.

This fixes the issue and adds tests that actually showed it.

Reviewed By: sammy-SC

Differential Revision: D56761941
    @rubennorte @facebook-github-bot
    rubennorte authored and facebook-github-bot committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c1c8991 View commit details
    Browse the repository at this point in the history