Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateTemplatePackage.js → updatePackage.js #44488

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented May 8, 2024

Summary:
As part of RFC-0759 we're moving away from the community CLI and using the helloworld template for our testing.

Changes:

This updatePackage now changes helloworld and the template's package.json. Previously it just touched the template.

  • snapshots update
  • made sure that helloworld/package.json's react-native is always 1000.0.0. It should always test whatever is in the repo with it at a particular commit.

Coming soon:

  • moving CircleCI to using the helloworld/cli scripts
  • removing the template and this method's support for bumping the template version

Changelog: [General][Changed] set-version supports helloworld and template

Differential Revision: D56629748

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56629748

@analysis-bot
Copy link

analysis-bot commented May 8, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,390 +13
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,582 +6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8d0046a
Branch: main

blakef added 6 commits May 8, 2024 07:04
Summary:

Contains a *light* wrapper to help launch Metro and build bundles or wait for localhost requests against Metro's dev-server. 

Changelog: [Internal]

Differential Revision: D57067040
Summary:

Helper methods to help the cli grab system state, devices and run react-native/core-cli-utils tasks using Listr.

Changelog: [Internal]

Differential Revision: D57067037
Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Reviewed By: cipolleschi

Differential Revision: D57066094
Summary:

Adds `app` to allow building and serving your React Native app in a similar structure to the boostrap and build tasks.  This is the more comprehensive followup to D57067040.

Changelog: [Internal]

Differential Revision: D57067039
Summary:

Allows us to `yarn build ios` the helloworld app.

Changelog: [Internal]

Differential Revision: D57067038
Summary:
As part of RFC-0759 we're moving away from the community CLI and using the helloworld template for our testing.

## Changes:
This `updatePackage` now changes helloworld and the template's `package.json`.  Previously it just touched the template.

- snapshots update
- made sure that `helloworld/package.json`'s `react-native` is always 1000.0.0.  This means that when `helloworld` is built, it always uses `react-native` @ same commit.

## Coming soon:
- moving CircleCI to using the helloworld/cli scripts
- removing the template and this method's support for bumping the template version

Changelog: [General][Changed] set-version supports helloworld and template

Differential Revision: D56629748
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56629748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants