Fix bridgeless triggering reloads twice from BridgelessDevSupportManager #44554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57112152 |
Base commit: 95f7a5c |
javache
added a commit
to javache/react-native
that referenced
this pull request
May 14, 2024
…ger (facebook#44554) Summary: Noticed than when reload is triggered by Metro (`handleReloadJS`), the application would often get stuck and not respond to further reload commands. Often an IOException would get printed as well, due to concurrent bundle loads happening. Changelog: [Android][Fixed] Improved resiliency of reloads when bundle loading fails Differential Revision: D57112152
|
This pull request was exported from Phabricator. Differential Revision: D57112152 |
javache
added a commit
to javache/react-native
that referenced
this pull request
May 14, 2024
…ger (facebook#44554) Summary: Noticed than when reload is triggered by Metro (`handleReloadJS`), the application would often get stuck and not respond to further reload commands. Often an IOException would get printed as well, due to concurrent bundle loads happening. Changelog: [Android][Fixed] Improved resiliency of reloads when bundle loading fails Differential Revision: D57112152
javache
added a commit
to javache/react-native
that referenced
this pull request
May 14, 2024
…upportManager (facebook#44554) Summary: Noticed than when reload is triggered by Metro (`handleReloadJS`), the application would often get stuck and not respond to further reload commands. Often an IOException would get printed as well, due to concurrent bundle loads happening. Changelog: [Android][Fixed] Improved resiliency of reloads when bundle loading fails Differential Revision: D57112152
…ger (facebook#44554) Summary: Noticed than when reload is triggered by Metro (`handleReloadJS`), the application would often get stuck and not respond to further reload commands. Often an IOException would get printed as well, due to concurrent bundle loads happening. Changelog: [Android][Fixed] Improved resiliency of reloads when bundle loading fails Reviewed By: RSNara Differential Revision: D57112152
|
This pull request was exported from Phabricator. Differential Revision: D57112152 |
|
This pull request has been merged in 524e3ee. |
|
This pull request was successfully merged by @javache in 524e3ee. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed than when reload is triggered by Metro (
handleReloadJS), the application would often get stuck and not respond to further reload commands. Often an IOException would get printed as well, due to concurrent bundle loads happening.Changelog: [Android][Fixed] Improved resiliency of reloads when bundle loading fails
Differential Revision: D57112152