Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate test case for TextExample in preparation of rntester android onboarding #44617

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Deduplicate test case for TextExample in preparation of rntester android onboarding #44617

wants to merge 4 commits into from

Commits on May 20, 2024

  1. [skip ci] Configure ViewHierarchy dump for RNTester 

    Summary: Changelog: [Android][Added] add FBEndToEndDumpsysHelper stub to RNTester Android to be able to dump ViewHierarcies internally.

Reviewed By: makovkastar

Differential Revision: D54662739
    @GijsWeterings @facebook-github-bot
    GijsWeterings authored and facebook-github-bot committed May 20, 2024
    Configuration menu
    Copy the full SHA
    5a38eeb View commit details
    Browse the repository at this point in the history

  2. [skip ci] Allow Deeplinking via Linking.getInitialURL() (facebook#44552) 

    Summary:

Changelog: [Android][Fixed] If the RNTester app is started with a deeplink intent, we now correctly navigate there for Android to facilitate e2e testing. This already worked on ios.

Reviewed By: javache

Differential Revision: D54662737
    @GijsWeterings @facebook-github-bot
    GijsWeterings authored and facebook-github-bot committed May 20, 2024
    Configuration menu
    Copy the full SHA
    86741f4 View commit details
    Browse the repository at this point in the history

  3. [skip ci] default the RNTTestDetails to collapsed by default 

    Summary:
tsia. Done to allow for easier interaction of the examples, especially those with long descriptions

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D57278607
    @GijsWeterings @facebook-github-bot
    GijsWeterings authored and facebook-github-bot committed May 20, 2024
    Configuration menu
    Copy the full SHA
    961cf38 View commit details
    Browse the repository at this point in the history

  4. Deduplicate test case for TextExample in preparation of rntester andr… 

    …oid onboarding

Summary:
D57197676 reordered the TextExample test cases, but accidentally reused the same string as the case in packages/rn-tester/js/examples/Text/TextInlineViewsExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D57279961
    @GijsWeterings @facebook-github-bot
    GijsWeterings authored and facebook-github-bot committed May 20, 2024
    Configuration menu
    Copy the full SHA
    ce42e0e View commit details
    Browse the repository at this point in the history