Align with code-gen output Sample Turbo Modules #44640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57624824 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 21, 2024
Summary: These modules are manually typed and don't use `react-native-codgen` (as a show case to demonstrates what code-gen produces). There are some typos in the manually written code and they don't exactly match the JS Spec used at runtime: https://github.com/facebook/react-native/blob/main/packages/react-native/src/private/specs/modules/NativeSampleTurboModule.js#L45-L48 Changelog: [Internal][Fixed] Align with code-gen output Sample Turbo Modules Differential Revision: D57624824
christophpurrer
force-pushed
the
export-D57624824
branch
from
95968f9
to
c5e0e10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57624824 |
Summary: These modules are manually typed and don't use `react-native-codgen` (as a show case to demonstrates what code-gen produces). There are some typos in the manually written code and they don't exactly match the JS Spec used at runtime: https://github.com/facebook/react-native/blob/main/packages/react-native/src/private/specs/modules/NativeSampleTurboModule.js#L45-L48 Changelog: [Internal][Fixed] Align with code-gen output Sample Turbo Modules Differential Revision: D57624824
christophpurrer
force-pushed
the
export-D57624824
branch
from
c5e0e10
to
5d9dffc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57624824 |
Base commit: cd1ddbb |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 21, 2024
Summary: These modules are manually typed and don't use `react-native-codgen` (as a show case to demonstrates what code-gen produces). There are some typos in the manually written code and they don't exactly match the JS Spec used at runtime: https://github.com/facebook/react-native/blob/main/packages/react-native/src/private/specs/modules/NativeSampleTurboModule.js#L45-L48 Changelog: [Internal][Fixed] Align with code-gen output Sample Turbo Modules Differential Revision: D57624824
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 21, 2024
Summary: These modules are manually typed and don't use `react-native-codgen` (as a show case to demonstrates what code-gen produces). There are some typos in the manually written code and they don't exactly match the JS Spec used at runtime: https://github.com/facebook/react-native/blob/main/packages/react-native/src/private/specs/modules/NativeSampleTurboModule.js#L45-L48 Changelog: [Internal][Fixed] Align with code-gen output Sample Turbo Modules Differential Revision: D57624824
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 22, 2024
…4640) Summary: These modules are manually typed and don't use `react-native-codgen` (as a show case to demonstrates what code-gen produces). There are some typos in the manually written code and they don't exactly match the JS Spec used at runtime: https://github.com/facebook/react-native/blob/main/packages/react-native/src/private/specs/modules/NativeSampleTurboModule.js#L45-L48 Changelog: [Internal][Fixed] Align with code-gen output Sample Turbo Modules Differential Revision: D57624824
|
This pull request has been merged in 24aed6e. |
|
This pull request was successfully merged by @christophpurrer in 24aed6e. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44640 These modules are manually typed and don't use `react-native-codgen` (as a show case to demonstrates what code-gen produces). There are some typos in the manually written code and they don't exactly match the JS Spec used at runtime: https://github.com/facebook/react-native/blob/main/packages/react-native/src/private/specs/modules/NativeSampleTurboModule.js#L45-L48 Changelog: [Internal][Fixed] Align with code-gen output Sample Turbo Modules Reviewed By: rshest Differential Revision: D57624824 fbshipit-source-id: 023f2318630aa342758d5ea495e6298cb8884ae1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These modules are manually typed and don't use
react-native-codgen(as a show case to demonstrates what code-gen produces).There are some typos in the manually written code and they don't exactly match the JS Spec used at runtime:
https://github.com/facebook/react-native/blob/main/packages/react-native/src/private/specs/modules/NativeSampleTurboModule.js#L45-L48
Changelog: [Internal][Fixed] Align with code-gen output Sample Turbo Modules
Differential Revision: D57624824