remove one_sided_type_guards option from flowconfigs (on by default) #45349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59525192 |
…acebook#45349) Summary: Pull Request resolved: facebook#45349 This is on by default as of version 0.239.0: https://github.com/facebook/flow/blob/v0.239/src/commands/config/flowConfig.ml#L268 Changelog: [Internal] Differential Revision: D59525192
|
This pull request was exported from Phabricator. Differential Revision: D59525192 |
panagosg7
force-pushed
the
export-D59525192
branch
from
46d9a87
to
9e14858
Compare
Base commit: ef2e941 |
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Jul 9, 2024
…fault) Summary: X-link: facebook/react-native#45349 This is on by default as of version 0.239.0: https://github.com/facebook/flow/blob/v0.239/src/commands/config/flowConfig.ml#L268 Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D59525192 fbshipit-source-id: b4bf456e3c03a712f4c6f5d72d157b3abf8f9895
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Jul 9, 2024
Summary: X-link: facebook/react-native#45349 This is on by default as of version 0.239.0: https://github.com/facebook/flow/blob/v0.239/src/commands/config/flowConfig.ml#L268 Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D59525192 fbshipit-source-id: b4bf456e3c03a712f4c6f5d72d157b3abf8f9895
|
This pull request has been merged in 5daa899. |
|
This pull request was successfully merged by @panagosg7 in 5daa899. When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jul 9, 2024
Summary: X-link: facebook/react-native#45349 This is on by default as of version 0.239.0: https://github.com/facebook/flow/blob/v0.239/src/commands/config/flowConfig.ml#L268 Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D59525192 fbshipit-source-id: b4bf456e3c03a712f4c6f5d72d157b3abf8f9895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is on by default as of version 0.239.0:
https://github.com/facebook/flow/blob/v0.239/src/commands/config/flowConfig.ml#L268
Changelog: [Internal]
Differential Revision: D59525192