Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android tests are failing due to missing class #4857

Closed
ide opened this issue Dec 18, 2015 · 3 comments
Closed

Android tests are failing due to missing class #4857

ide opened this issue Dec 18, 2015 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Dec 18, 2015

https://circleci.com/gh/facebook/react-native/496

[x86] Install        : libreactnativejni.so => /home/ubuntu/react-native/ReactAndroid/build/react-ndk/all/x86/libreactnativejni.so
make: Leaving directory `/home/ubuntu/react-native/ReactAndroid/src/main/jni/react/jni'
:ReactAndroid:packageReactNdkLibs
:ReactAndroid:compileDebugJavaWithJavac/home/ubuntu/react-native/ReactAndroid/src/main/java/com/facebook/react/views/webview/ReactWebViewManager.java:32: error: package com.facebook.react.common.build does not exist
import com.facebook.react.common.build.ReactBuildConfig;
                                      ^
/home/ubuntu/react-native/ReactAndroid/src/main/java/com/facebook/react/views/webview/ReactWebViewManager.java:78: error: cannot find symbol
    if (ReactBuildConfig.DEBUG && Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
        ^
  symbol:   variable ReactBuildConfig
  location: class ReactWebViewManager

cc @mkonicek (probably need to add ReactBuildConfig for 8cd7730)
@ide
Copy link
Contributor Author

ide commented Dec 18, 2015

Also, this code runs on whatever thread loads the class but WebView.setWebContentsDebuggingEnabled needs to run on the UI thread so moving this out of a static initializer might make sense too.

@christopherdro christopherdro mentioned this issue Dec 18, 2015
Closed
@mkonicek
Copy link
Contributor

Thanks for keeping an eye on it. My commit broke it. Fixed here: a3d16c0

@ide
Copy link
Contributor Author

ide commented Dec 18, 2015

Thanks Martin!

odino added a commit to odino/react-native that referenced this issue Jan 1, 2016
@odino
Enables android webview debugging
464607f 
2 things that I want to clarify / ask for feedback:

* do we really need to make sure we're running on the UI thread? I guess `onPageStarted` maybe already runs there? Couldnt find anything [here](http://developer.android.com/reference/android/webkit/WebView.html) though
* everytime a page starts we reset this flag -- it's a bit useless but I also don't see the problem, as debugging should only be enabled in dev

Relates to issue facebook#4857, where we switched debugging off as, in some circumstances, it would crash the application as debugging was invoked outside the UI thread.
@odino odino mentioned this issue Jan 1, 2016
Closed
odino added a commit to odino/react-native that referenced this issue Jan 5, 2016
@odino
Enables android webview debugging
67e957e 
2 things that I want to clarify / ask for feedback:

* do we really need to make sure we're running on the UI thread? I guess `onPageStarted` maybe already runs there? Couldnt find anything [here](http://developer.android.com/reference/android/webkit/WebView.html) though
* everytime a page starts we reset this flag -- it's a bit useless but I also don't see the problem, as debugging should only be enabled in dev

Relates to issue facebook#4857, where we switched debugging off as, in some circumstances, it would crash the application as debugging was invoked outside the UI thread.
odino added a commit to odino/react-native that referenced this issue Jan 5, 2016
@odino
Enables android webview debugging
0f110be 
Relates to issue facebook#4857, where we switched debugging off as, in some circumstances, it would crash the application as debugging was invoked outside the UI thread.
ghost pushed a commit that referenced this issue Jan 5, 2016
@odino
Enables webview debugging
2462c8f 
Summary:
2 things that I want to clarify / ask for feedback:

* do we really need to make sure we're running on the UI thread? I guess `onPageStarted` maybe already runs there? Couldnt find anything [here](http://developer.android.com/reference/android/webkit/WebView.html) though
* everytime a page starts we re-enable debugging -- it's a bit useless but I also don't think it's a huge problem, as debugging should only be enabled in dev

Relates to issue #4857, where we switched debugging off as, in some circumstances, it would crash the application as debugging was invoked outside the UI thread.
Closes #5071

Reviewed By: svcscm

Differential Revision: D2803649

Pulled By: astreet

fb-gh-sync-id: 523d3b442b196d6c54b14ba0c2b29601095c3363
christopherdro pushed a commit to wildlifela/react-native that referenced this issue Jan 20, 2016
@odino @christopherdro
Enables webview debugging
d41a504 
Summary:
2 things that I want to clarify / ask for feedback:

* do we really need to make sure we're running on the UI thread? I guess `onPageStarted` maybe already runs there? Couldnt find anything [here](http://developer.android.com/reference/android/webkit/WebView.html) though
* everytime a page starts we re-enable debugging -- it's a bit useless but I also don't think it's a huge problem, as debugging should only be enabled in dev

Relates to issue facebook#4857, where we switched debugging off as, in some circumstances, it would crash the application as debugging was invoked outside the UI thread.
Closes facebook#5071

Reviewed By: svcscm

Differential Revision: D2803649

Pulled By: astreet

fb-gh-sync-id: 523d3b442b196d6c54b14ba0c2b29601095c3363
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkonicek @ide @react-native-bot