[Packager] add host argument for packager. #5377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @martinbigio, @ide and @davidaurelio to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1547910852202006/int_phab to review. |
ghost
closed this
in
christopherdro
pushed a commit
to wildlifela/react-native
that referenced
this pull request
Jan 20, 2016
Summary: Now packager only listen to "::", which is IPv6 "Any address". It failed to run in IPv4 Environment. defaults to undefined or empty string will fix this. And I think it's necessary to let user define host by cli argument. It's also for security reason. When working on a public network, it's much safer to listen with localhost instead of ::, which may let everyone in same network be able to get your code from debugger-ui. recommit for facebook#1918, fixes facebook#2441 Closes facebook#5377 Reviewed By: svcscm Differential Revision: D2842594 Pulled By: martinbigio fb-gh-sync-id: 575944c5469dac80e99136a7903ea99f5339dba1
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Jan 21, 2016
Summary: Now packager only listen to "::", which is IPv6 "Any address". It failed to run in IPv4 Environment. defaults to undefined or empty string will fix this. And I think it's necessary to let user define host by cli argument. It's also for security reason. When working on a public network, it's much safer to listen with localhost instead of ::, which may let everyone in same network be able to get your code from debugger-ui. recommit for facebook#1918, fixes facebook#2441 Closes facebook#5377 Reviewed By: svcscm Differential Revision: D2842594 Pulled By: martinbigio fb-gh-sync-id: 575944c5469dac80e99136a7903ea99f5339dba1
brentvatne
pushed a commit
to expo/react-native
that referenced
this pull request
Jan 22, 2016
Summary: Now packager only listen to "::", which is IPv6 "Any address". It failed to run in IPv4 Environment. defaults to undefined or empty string will fix this. And I think it's necessary to let user define host by cli argument. It's also for security reason. When working on a public network, it's much safer to listen with localhost instead of ::, which may let everyone in same network be able to get your code from debugger-ui. recommit for facebook#1918, fixes facebook#2441 Closes facebook#5377 Reviewed By: svcscm Differential Revision: D2842594 Pulled By: martinbigio fb-gh-sync-id: 575944c5469dac80e99136a7903ea99f5339dba1
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Now packager only listen to "::", which is IPv6 "Any address". It failed to run in IPv4 Environment. defaults to undefined or empty string will fix this. And I think it's necessary to let user define host by cli argument. It's also for security reason. When working on a public network, it's much safer to listen with localhost instead of ::, which may let everyone in same network be able to get your code from debugger-ui. recommit for #1918, fixes #2441 Closes facebook/react-native#5377 Reviewed By: svcscm Differential Revision: D2842594 Pulled By: martinbigio fb-gh-sync-id: 575944c5469dac80e99136a7903ea99f5339dba1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now packager only listen to "::", which is IPv6 "Any address".
It failed to run in IPv4 Environment.
defaults to undefined or empty string will fix this.
And I think it's necessary to let user define host by cli argument.
It's also for security reason. When working on a public network, it's much safer to listen with localhost instead of ::, which may let everyone in same network be able to get your code from debugger-ui.
recommit for #1918, fixes #2441