[packager] breaking test and fix for browser field mapping from package to file #5505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
added fix |
mvayngrib
changed the title
|
@mvayngrib updated the pull request. |
mvayngrib
force-pushed
the
browserMappingBreakingTest
branch
from
e1ed4b7
to
856e103
Compare
|
@mvayngrib updated the pull request. |
|
Thanks @mvayngrib! |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1700682636814686/int_phab to review. |
ghost
closed this
in
doostin
pushed a commit
to doostin/react-native
that referenced
this pull request
Feb 1, 2016
Summary:
breaks on mappings like:
```json
"browser": {
"node-package": "./dir/browser.js"
}
```
Closes facebook#5505
Reviewed By: svcscm
Differential Revision: D2860579
Pulled By: androidtrunkagent
fb-gh-sync-id: 0d64c0999c47a6cbbf084cc8e0c8a6ea209b0880
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary:
breaks on mappings like:
```json
"browser": {
"node-package": "./dir/browser.js"
}
```
Closes facebook/react-native#5505
Reviewed By: svcscm
Differential Revision: D2860579
Pulled By: androidtrunkagent
fb-gh-sync-id: 0d64c0999c47a6cbbf084cc8e0c8a6ea209b0880
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaks on mappings like: