Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using local-cli in gradle #6272

Closed
wants to merge 1 commit into from
Closed

Using local-cli in gradle #6272

wants to merge 1 commit into from

Conversation

farwayer
Copy link
Contributor

@farwayer farwayer commented Mar 3, 2016

Same as d87d127 but for gradle. It will help to prevent installing global react-native-cli (more simple CI server configuration for ex.)
Tested on Linux and Windows.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @AndrewJack, @foghina and @jaggs6 to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 3, 2016
@farwayer farwayer mentioned this pull request Mar 3, 2016
Closed
@AndrewJack
Copy link
Contributor

👍 Nice!

@farwayer
Copy link
Contributor Author

farwayer commented Mar 4, 2016

Look like CI failed with emulator timeout. I tested locally and all ok with that test.

@jaggs6
Copy link
Contributor

jaggs6 commented Mar 4, 2016

@farwayer Just amend the commit message and force push it trigger the build

@farwayer
Copy link
Contributor Author

farwayer commented Mar 4, 2016

Made it, ty

@foghina
Copy link
Contributor

foghina commented Mar 21, 2016

@farwayer what distro of Linux did you test this on? I think Ubuntu (which is the most popular one) names the binary nodejs instead of node by default.

@farwayer
Copy link
Contributor Author

Creating symlink from node to nodejs is described in the installation guide.
In short: this is debian problem (and ubuntu as based on debian). More info is here.
All other world (OSX, Windows, other non-debian dists) names binary node as official name.
react-native-cli and user project package.json also uses node as binary name.

@foghina
Copy link
Contributor

foghina commented Mar 21, 2016

I don't see any mention of symlinking in the guide you linked to. It does mention using packages from nodesource.com instead of the default ones, but I can't find a file list for those packages to determine whether they provide a node binary.

Anyway, if we use this in other places as you pointed out in package.json it's probably fine.

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@farwayer
Copy link
Contributor Author

I don't see any mention of symlinking in the guide you linked to

sudo ln -s /usr/bin/nodejs /usr/bin/node

@foghina
Copy link
Contributor

foghina commented Mar 21, 2016

Damn, I must be blind.

turns on screen reader

@ghost ghost closed this in dcf4600 Mar 21, 2016
jeffchienzabinet pushed a commit to jeffchienzabinet/react-native that referenced this pull request Mar 21, 2016
@farwayer @jeffchienzabinet
Using local-cli in gradle
ca6fa47 
Summary:Same as d87d127 but for gradle. It will help to prevent installing global `react-native-cli` (more simple CI server configuration for ex.)
Tested on Linux and Windows.
Closes facebook#6272

Differential Revision: D3076101

Pulled By: foghina

fb-gh-sync-id: 89c3870536b1ce3fdbb909909b887f3ce68b2951
shipit-source-id: 89c3870536b1ce3fdbb909909b887f3ce68b2951
jordaaash pushed a commit to jordaaash/react-native that referenced this pull request Mar 22, 2016
@farwayer @jordaaash
Using local-cli in gradle
0464cc3 
Summary:Same as d87d127 but for gradle. It will help to prevent installing global `react-native-cli` (more simple CI server configuration for ex.)
Tested on Linux and Windows.
Closes facebook#6272

Differential Revision: D3076101

Pulled By: foghina

fb-gh-sync-id: 89c3870536b1ce3fdbb909909b887f3ce68b2951
shipit-source-id: 89c3870536b1ce3fdbb909909b887f3ce68b2951
@farwayer farwayer deleted the local-gradle-cli branch June 16, 2016 19:03
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@farwayer
Using local-cli in gradle
d97c1b9 
Summary:Same as d87d127 but for gradle. It will help to prevent installing global `react-native-cli` (more simple CI server configuration for ex.)
Tested on Linux and Windows.
Closes facebook/react-native#6272

Differential Revision: D3076101

Pulled By: foghina

fb-gh-sync-id: 89c3870536b1ce3fdbb909909b887f3ce68b2951
shipit-source-id: 89c3870536b1ce3fdbb909909b887f3ce68b2951
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@farwayer @facebook-github-bot @AndrewJack @jaggs6 @foghina