Fix Promise argument assertion to take into account executorTokenOffset. #6633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @davidaurelio, @mkonicek and @lexs to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
I'll let @astreet take a look. |
|
This looks like it does the right thing but I think semantically we want to check if |
ide
force-pushed
the
fix-promise-argument-assertion
branch
from
ee4c03b
to
c4e04a8
Compare
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:In the code that extracts and validates arguments from a `ReactMethod`, there is verification that if a method contains a Promise in it's list of arguments that it must come last. This fix makes sure that the `executorTokenOffset` is taken into account when asserting that condition. Closes facebook#6633 Differential Revision: D3143207 fb-gh-sync-id: ae9ebd9d829f88993f9951c4cb2452b3f7618476 fbshipit-source-id: ae9ebd9d829f88993f9951c4cb2452b3f7618476
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code that extracts and validates arguments from a
@ReactMethod, there is verification that if a method contains a Promise in it's list of arguments that it must come last. This fix makes sure that theexecutorTokenOffsetis taken into account when asserting that condition.Test Plan: Add a Promise argument to a
@ReactMethodannotated method in a module that supports web workers, and observe a successful build.cc @astreet