Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Getting Started labels a bit more clear #7674

Closed
wants to merge 1 commit into from
Closed

Make Getting Started labels a bit more clear #7674

wants to merge 1 commit into from

Conversation

JoelMarcey
Copy link

"Target" over "Platform" to represent target for your RN app
"Development OS" over "OS" to represent your RN Development environment

screenshot 2016-05-21 09 48 47

"Target" over "Platform" to represent target for your RN app
"Development OS" over "OS" to represent your RN Development environment
@ghost
Copy link

ghost commented May 21, 2016

By analyzing the blame information on this pull request, we identified @willfong and @atifmansoor to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 21, 2016
@janicduplessis
Copy link
Contributor

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 21, 2016
@ghost
Copy link

ghost commented May 21, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 14dd384 May 21, 2016
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
Summary:
"Target" over "Platform" to represent target for your RN app
"Development OS" over "OS" to represent your RN Development environment

<img width="526" alt="screenshot 2016-05-21 09 48 47" src="https://cloud.githubusercontent.com/assets/3757713/15449679/87e1c9fa-1f39-11e6-99e9-822c2022c4db.png">
Closes facebook#7674

Differential Revision: D3332780

fbshipit-source-id: b0acfc843e00a9bd71b940c5f51507667ba5123e
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Summary:
"Target" over "Platform" to represent target for your RN app
"Development OS" over "OS" to represent your RN Development environment

<img width="526" alt="screenshot 2016-05-21 09 48 47" src="https://cloud.githubusercontent.com/assets/3757713/15449679/87e1c9fa-1f39-11e6-99e9-822c2022c4db.png">
Closes facebook#7674

Differential Revision: D3332780

fbshipit-source-id: b0acfc843e00a9bd71b940c5f51507667ba5123e
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants