Support running the packager on Windows #781
Conversation
The discovered file paths returned by node have backslash on Windows, so the test was failing - essentially ignoring the blacklist.
When the packager is run from node_modules, there's some code in packager.js that tests for this and sets the project root to ../../.
Watchman doesn't currently work on windows and the fallback path can take longer to initialize, especially on slower machines.
facebook-github-bot
added
the
CLA Signed
|
I've been splitting out the changes and submitting as separate PRs. First one here: #807. |
|
Happy to let you do the PRs instead! I'll close this out then when I get back to my work machine. -----Original Message----- I've been splitting out the changes and submitting as separate PRs. First one here: #807. |
|
Closing so that @joewood can post these individually and respond to review comments. |
* Explicitly state that `activeOpacity` requires `underlayColor` It's clear from facebook#11834 that the underlying issue won't be fixed, so we should update the documentation so people understand that for `activeOpacity` to work, they need to set `underlayColor`. * Update touchablehighlight.md
These are all commits from issue #468 that I am turning into a pull request (thanks @joewood!). I am seeing different behavior between my laptop and desktop so I don't think this solves all the problems (ex: running
dirin a different terminal will cause the packager to crash) but it's a start.