Fixes EventEmitter#once arguments not getting passed to the listener #8479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to pass the correct arguments to the listener callback. Closes facebook#8477
|
By analyzing the blame information on this pull request, we identified @nicklockwood and @rahuljiresal to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Arrow functions do not have their own arguments. Fix EventEmitter#once to pass the correct arguments to the listener callback. Closes facebook#8479 Differential Revision: D3495086 Pulled By: javache fbshipit-source-id: 4492d13bfb2cc255afdc41d39fbf2f35da6b7094
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Arrow functions do not have their own arguments. Fix EventEmitter#once to pass the correct arguments to the listener callback. Closes facebook#8479 Differential Revision: D3495086 Pulled By: javache fbshipit-source-id: 4492d13bfb2cc255afdc41d39fbf2f35da6b7094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow functions do not have their own arguments. Fix EventEmitter#once to pass the correct arguments to the listener callback.