Android WebView “tel:” links show web page not found - issue fixed

[sathyapriya31]

Submitting PR #6810 - Android WebView “tel:” links show web page not found - issue fixed.
'tel:' link web page not loading:

After Fixing the issue:

[ghost]

By analyzing the blame information on this pull request, we identified @mkonicek and @nicklockwood to be potential reviewers.

[ghost]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

[christopherdro]

nit: space before {

[satya164]

I don't think checking for tel: is the right way to do it. What about mailto:, or any custom schemes?

I think we should check if the URL is not http: or https:, then handle it. It'll probably suffice to just use a Intent.ACTION_VIEW for all URLs. In case of tel:, it won't dial the number, but will probably open the dialer with the number.

[satya164]

Does it work without the flag Intent.FLAG_ACTIVITY_NEW_TASK? We should use the current activity to start the intent (which doesn't need the flag) if we can. It provides better UX since most of the time the user can press back to come to the previous screen.

[satya164]

Please check if it is http or https before handling.

Also does startActivity work without FLAG_NEW_TASK

[wv1124]

@Override
public boolean shouldOverrideUrlLoading(WebView view, String url) {
  if (url.startsWith("tel:") || url.startsWith("sms:") || url.startsWith("smsto:") || url.startsWith("mms:") || url.startsWith("mmsto:")) {
    ReactContext reactContext = (ReactContext) view.getContext();
    Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
    reactContext.startActivity(intent);
    return true;
  }
  return false;
}

[sathyapriya31]

@satya164

public boolean shouldOverrideUrlLoading(WebView view, String url) {
        ReactContext reactContext = (ReactContext) view.getContext();
        if(url.startsWith("http")|| url.startsWith("http")) {
          return false;
        } else {
          Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url)); 
          intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
          reactContext.startActivity(intent);   
          return true;   
        }   
    }

Is this Correct? shall i proceed?

[satya164]

It should be url.startsWith("https") || url.startsWith("http"), otherwise looks correct. Please also test that the code works.

[satya164]

Also, do you need to cast this to ReactContext - (ReactContext) view.getContext();? It should work without casting.

[wv1124]

@Override
public boolean shouldOverrideUrlLoading(WebView view, String url) {
  if (url.startsWith("tel:") || url.startsWith("sms:") || url.startsWith("smsto:") || url.startsWith("mms:") || url.startsWith("mmsto:")) {
    ReactContext reactContext = (ReactContext) view.getContext();
    Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
    reactContext.startActivity(intent);
    return true;
  }
  return false;
}

[satya164]

nit: space after if and before ||

[ide]

better to check for http:// and https://

[satya164]

@facebook-github-bot shipit

[ghost]

Thanks for importing. If you are an FB employee go to Phabricator to review.