Update Switch.js docs - tintColor changes border #9707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @yungsters and @davidaurelio to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
facebook-github-bot
added
the
CLA Signed
|
@Piwaii updated the pull request - view changes |
ghost
added
the
CLA Signed
|
@Piwaii updated the pull request - view changes |
ghost
added
the
CLA Signed
|
Ah, good catch! Wonder why it said background - could it be that it's the background on older iOS versions? Could you add a screenshot please showing how the tinted switch looks? This is from the
Looks like it's indeed the border that turns red. |
mkonicek
changed the title
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for Switch as it's not a background color that is displayed when the switch off, but juste the border (the background remains transparent)