Skip to content

Commit

Permalink
Add todo for bug I spotted
Browse files Browse the repository at this point in the history
  • Loading branch information
sebmarkbage committed Sep 5, 2019
1 parent fbaca52 commit 38737b5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/react-reconciler/src/ReactFiberBeginWork.js
Original file line number Diff line number Diff line change
Expand Up @@ -938,6 +938,9 @@ function updateHostRoot(current, workInProgress, renderExpirationTime) {
}
const root: FiberRoot = workInProgress.stateNode;
if (
// TODO: This is a bug because if we render null after having hydrating,
// we'll reenter hydration state at the next update which will then
// trigger hydration warnings.
(current === null || current.child === null) &&
root.hydrate &&
enterHydrationState(workInProgress)
Expand Down

0 comments on commit 38737b5

Please sign in to comment.