Rework conditions in shouldSetProperty to avoid edge cases

facebook · Aug 3, 2017 · be4c932 · be4c932
1 parent 8d775f8
commit be4c932
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/src/renderers/dom/shared/DOMProperty.js b/src/renderers/dom/shared/DOMProperty.js
@@ -220,13 +220,24 @@ var DOMProperty = {
       return false;
     }
 
-    if (value == null || DOMProperty.properties.hasOwnProperty(name)) {
+    let type = typeof value;
+
+    if (
+      value === null ||
+      type === 'undefined' ||
+      DOMProperty.properties.hasOwnProperty(name)
+    ) {
       return true;
     }
 
-    let type = typeof value;
-
-    return type !== 'function' && type !== 'object';
+    switch (type) {
+      case 'boolean':
+      case 'number':
+      case 'string':
+        return true;
+      default:
+        return false;
+    }
   },
 
   /**