New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to publish preleases via CI #20728
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5ea577a:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't have to be done now :) But let's not forget to update this fella:
https://github.com/facebook/react/blob/master/scripts/release/README.md
``` yarn publish-prereleases ``` Script to trigger a CircleCI workflow that publishes preleases. **The CI workflow doesn't actually publish yet; it just runs and logs its inputs.**
dbafff8
to
5ea577a
Compare
Size changesComparing: 00e38c8...5ea577a Stable channelNo significant bundle size changes to report. Experimental channelNo significant bundle size changes to report. |
PR facebook#20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
PR facebook#20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
PR facebook#20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
PR facebook#20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
PR #20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
``` yarn publish-prereleases ``` Script to trigger a CircleCI workflow that publishes preleases. **The CI workflow doesn't actually publish yet; it just runs and logs its inputs.**
PR facebook#20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
Script to trigger a CircleCI workflow that publishes prereleases.
The CI workflow doesn't actually publish yet; it just runs and logs its inputs.
Output: