Implement CI publish prerelease job #20732
Merged
+38
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab3712d:
|
Size changesComparing: 4c01958...97daa52 Stable channelNo significant bundle size changes to report. Experimental channelNo significant bundle size changes to report. |
acdlite
force-pushed
the
ci-publish
branch
2 times, most recently
from
8451901 to
ab3712d
Compare
PR facebook#20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
acdlite
force-pushed
the
ci-publish
branch
2 times, most recently
from
8df35fb to
97daa52
Compare
rickhanlonii
approved these changes
Feb 4, 2021
bvaughn
reviewed
Feb 4, 2021
| # TODO: This doesn't actually publish anything yet. Just logs the inputs. | ||
| - run: | | ||
| echo "<< parameters.commit_sha >>" | ||
| echo "<< parameters.release_channel >>" |
Contributor
There was a problem hiding this comment.
Ooh, what about the other publish_preleases with a #TODO at the bottom?
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
PR facebook#20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job. Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel. Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully. It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally. Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #20728 added a command to initiate a prerelease using CI, but it left the publish job unimplemented. This fills in the publish job.
Uses an npm automation token for authorization, which bypasses the need for a one-time password. The token is configured via CircleCI's environment variable panel.
Currently, it will always publish the head of the main branch. If the head has already been published, it will exit gracefully.
It does not yet support publishing arbitrary commits, though we could easily add that. I don't know how important that use case is, because for PR branches, you can use CodeSandbox CI instead. Or as a last resort, run the publish script locally.
Always publishing from main is nice because it further incentivizes us to keep main in a releasable state. It also takes the guesswork out of publishing a prerelease that's in a broken state: as long as we don't merge broken PRs, we're fine.
Test plan
Corresponding CI workflow that successfully published: https://app.circleci.com/pipelines/github/facebook/react/9764/workflows/894684e1-f09f-4c40-9310-65603cf3eb9e