-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8-10: Warning: Component(...): React component classes must extend React.Component. #4990
Comments
I realized this last week and didn't get a chance to test it. Glad to know it's not entirely in my head. We'll figure out a fix. |
Merging into #4990. |
@spicyj Merging into self? Is there a different issue you intended to link? |
Thanks, I meant #4836. |
It hasn't been fixed. #4836 will have updates when it is (which will happen before 0.14). |
@spicyj will this currently have any negative effect on production code or is it only a warning in I'm using the syntax import React, {Component} from 'react';
class Whatevsss extends Component { not sure if it is effected by just doing class Whatevsss extends React.Component { |
Both of those are fine. In prod mode we skip the check but your code will break in 0.15 if it's triggering the warning now. |
Transpiled with babeljs. Not observed in modern browsers.
It's possible this is actually an issue with babeljs, I'm not really sure.
cc @spicyj
The text was updated successfully, but these errors were encountered: