-
Notifications
You must be signed in to change notification settings - Fork 46.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onScroll doesn't work in IE8 #631
Comments
I tried to fix this bug yesterday but had a bad time trying to find a fix for a similar cases. http://www.quirksmode.org/dom/events/tests/scroll.html |
Seems like this isn't so easy. Let's do what @fabiomcosta says and document it. |
@zpao do you think that we should do a |
+1 on the warning -- would be super helpful. |
reopening so we can add a warning |
Adding `console.warn` about the lack of support for `onScroll` event on IE8 Related to this issue on github #631
Warning was added in f3e7745 |
Now that events are listened on demand, maybe the warning should be moved to |
Adding `console.warn` about the lack of support for `onScroll` event on IE8 Related to this issue on github #631
It also prints the warning if you render on the server, its annoying :/ |
That's odd, I wouldn't expect that code to run at all when using server rendering. |
I see this warning when I'm doing |
I also see this error when using ssr |
This is happening to me with JSDOM as well and in my case our team project standards aren't going to accommodate leaving these errors in the console when tests are run. How can I suppress or stub this out. It's not just obnoxious it is preventing me from getting my work merged in our project. |
If you're having problems please file a new issue. |
Here's an example: (no jsfiddle because that's broken in IE8)
http://playground.zpao.com/react/onscroll.html
The text was updated successfully, but these errors were encountered: