Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onScroll doesn't work in IE8 #631

Closed
zpao opened this issue Dec 4, 2013 · 14 comments · Fixed by #703
Closed

onScroll doesn't work in IE8 #631

zpao opened this issue Dec 4, 2013 · 14 comments · Fixed by #703

Comments

@zpao
Copy link
Member

zpao commented Dec 4, 2013

Here's an example: (no jsfiddle because that's broken in IE8)

http://playground.zpao.com/react/onscroll.html

@fabiomcosta
Copy link
Contributor

I tried to fix this bug yesterday but had a bad time trying to find a fix for a similar cases.
I looked at current well maintained libraries and didn't find a way to make scroll bubble or capture it on IE8.
Seems like trying to fix it would be a waste of time and would make code much complex, for a browser that is slowly dying.
My suggestion is to point that out on the documentation.

http://www.quirksmode.org/dom/events/tests/scroll.html
http://dojotoolkit.org/reference-guide/1.9/dojo/on.html#event-delegation
http://api.jquery.com/on/#additional-notes

@zpao
Copy link
Member Author

zpao commented Dec 22, 2013

Seems like this isn't so easy. Let's do what @fabiomcosta says and document it.

@fabiomcosta
Copy link
Contributor

@zpao do you think that we should do a console.warn everytime someone uses onScroll on any browser or would that be annoying? I would say it would be annoying but it would also be very frustrating to figure that it's a React limitation after some hours of debugging on IE8 (ugh!)

@petehunt
Copy link
Contributor

+1 on the warning -- would be super helpful.

@petehunt
Copy link
Contributor

reopening so we can add a warning

@petehunt petehunt reopened this Dec 24, 2013
zpao pushed a commit that referenced this issue Jan 3, 2014
Adding `console.warn` about the lack of support for `onScroll` event on IE8
Related to this issue on github #631
@cpojer
Copy link
Contributor

cpojer commented Jan 3, 2014

Warning was added in f3e7745

@cpojer cpojer closed this as completed Jan 3, 2014
@plievone
Copy link
Contributor

plievone commented Jan 5, 2014

Now that events are listened on demand, maybe the warning should be moved to ReactEventEmitter.listenTo method, where support is already checked?

vjeux pushed a commit that referenced this issue Jan 6, 2014
Adding `console.warn` about the lack of support for `onScroll` event on IE8
Related to this issue on github #631
@rakeshok
Copy link

rakeshok commented Nov 3, 2015

It also prints the warning if you render on the server, its annoying :/

@sophiebits
Copy link
Collaborator

That's odd, I wouldn't expect that code to run at all when using server rendering.

@vmakhaev
Copy link

I see this warning when I'm doing TestUtils.renderIntoDocument with node-jsdom. Any chance to disable it?

@b2whats
Copy link

b2whats commented Apr 26, 2016

I also see this error when using ssr

@hammer65
Copy link

This is happening to me with JSDOM as well and in my case our team project standards aren't going to accommodate leaving these errors in the console when tests are run. How can I suppress or stub this out. It's not just obnoxious it is preventing me from getting my work merged in our project.

@anthonyhastings
Copy link

@vmakhaev / @hammer65 - I am now seeing this error after upgrading my version of Enzyme to 3.1.0. Did you find a way to suppress these warnings for JSDOM?

@gaearon
Copy link
Collaborator

gaearon commented Nov 7, 2017

If you're having problems please file a new issue.
Nobody actively reads old issues, and requests for help here will get lost.

@facebook facebook locked and limited conversation to collaborators Nov 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.