Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow namespacing in component names in JSX #74

Closed
sophiebits opened this issue Jun 7, 2013 · 9 comments · Fixed by #760
Closed

Allow namespacing in component names in JSX #74

sophiebits opened this issue Jun 7, 2013 · 9 comments · Fixed by #760

Comments

@sophiebits
Copy link
Contributor

23:07 < balpert> can we add <Namespaced.Things /> to JSX?
23:07 < jwalke> I like that you chose the dot!
23:07 < jwalke> Keep it javascript-first.
23:07 < balpert> yes
23:08 < balpert> translating colon to dot would be absurd
23:08 < balpert> (in my opinion)
23:08 < jwalke> So you could have var MyComponentsPackage = {Typeahead:
                R.createClass.. }
23:08 < jwalke> <MyComponentsPackage.Typeahead />
23:08 < jwalke> I like it.
23:08 < jwalke> Make an issue!
@jordwalke
Copy link
Contributor

👍

2 similar comments
@petehunt
Copy link
Contributor

petehunt commented Jun 9, 2013

+1

@hojberg
Copy link
Contributor

hojberg commented Jun 9, 2013

+1

@benjamn
Copy link
Contributor

benjamn commented Jun 11, 2013

I'mma jump on the 👍 bandwagon too. Great idea.

@jtmalinowski
Copy link
Contributor

I don't want to keep duplicated issues opened so just to sumup: @jeffmo said it makes sense to implement "namespacing" using colons as opt-in, config-defined option, where one of the possibilities would be a member expression. I don't have enough time to implement it this way, so I closed my issue. More on why&how in jeffmo's final comment #221 (comment) and in #221 in general

@vladise
Copy link

vladise commented Jan 12, 2014

+1

1 similar comment
@flashjames
Copy link

+1

@percyhanna
Copy link

A non JavaScript-first implementation that wouldn't require changes to facebook/esprima: #1221

@syranide
Copy link
Contributor

syranide commented May 9, 2014

PR landing for JSX member expressions #760, can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants