Regenerate error codes and update bundle size stats (#10287) #10288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We tested it locally and things look like they are working :)
|
|
It was unexpected that It looks like we were not putting the code with that error into the production build on master since the roll-up build system change, but before that we may not have been removing it properly. The problem is that now there are existing public React versions which could hit this error message, so we want to retain it in our list of error codes to document. We are adding it to the list on master and re-generating the error codes, then will cherry-pick the updated version. |
gaearon
approved these changes
Jul 26, 2017
flarnie
added a commit
to flarnie/react
that referenced
this pull request
Jul 26, 2017
A result of facebook#10288
Merged
flarnie
added a commit
that referenced
this pull request
Jul 26, 2017
* Update error codes A result of #10288 * Update the codes again
web-developer77
pushed a commit
to web-developer77/facebook-react
that referenced
this pull request
Jun 7, 2021
* Update error codes A result of facebook/react#10288 * Update the codes again
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
* Update error codes A result of facebook/react#10288 * Update the codes again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cherry-picked 8d5f2c4 onto 15-stable. This does not include the update to the size tracking file, since that doesn't exist on 15-stable.