Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to attribute whitelist logic #10564

Merged
merged 36 commits into from
Aug 31, 2017
Merged

Changes to attribute whitelist logic #10564

merged 36 commits into from
Aug 31, 2017

Commits on Aug 29, 2017

  1. Remove HTMLPropertyConfig entries for non-boolean values 

    When we originally removed attributes from the whitelist, we assumed a
few attributes were string booleans, but they are not:

Autocomplete ("on", "off")
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#autocomplete

Autocapitalize ("none", "sentence", "words", ...)
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#autocapitalize

Autocorrect ("on", "off")
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#autocorrect

Autosave (string)
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#autosave
    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    e10694a View commit details
    Browse the repository at this point in the history

  2. Only HAS_BOOLEAN_VALUE attribute flag can assign booleans

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    711bafe View commit details
    Browse the repository at this point in the history

  3. Use a non-boolean attribute in object assignment tests

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    4c5dfbb View commit details
    Browse the repository at this point in the history

  4. Add HAS_STRING_BOOLEAN_VALUE attribute flag

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    e086ff1 View commit details
    Browse the repository at this point in the history

  5. Fix boolean tests, add boolean warning.

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    0410651 View commit details
    Browse the repository at this point in the history

  6. Reserved props should allow booleans

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    ab75d9a View commit details
    Browse the repository at this point in the history

  7. Remove outdated comments

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    6077e0b View commit details
    Browse the repository at this point in the history

  8. Style tweaks

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    6f913ed View commit details
    Browse the repository at this point in the history

  9. Don't treat dashed SVG tags as custom elements

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    aca8d9c View commit details
    Browse the repository at this point in the history

  10. SVG elements like font-face are not custom attributes 

    - Adds exceptions to isCustomAttribute for dashed SVG elements
- Use consistent custom element check across all modules
    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    af7d035 View commit details
    Browse the repository at this point in the history

  11. Move namespace check to isCustomAttribute. Add caveat for stack.

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    1 Configuration menu
    Copy the full SHA
    9c0751f View commit details
    Browse the repository at this point in the history

  12. Remove unused namespace variable assignment

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    f8da44e View commit details
    Browse the repository at this point in the history

  13. Fix the DEV-only whitelist

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    b93e093 View commit details
    Browse the repository at this point in the history

  14. Don't read property twice

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    fbcced1 View commit details
    Browse the repository at this point in the history

  15. Ignore and warn about non-string is attribute

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    a270e03 View commit details
    Browse the repository at this point in the history

  16. Blacklist "aria" and "data" attributes

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    ed92af0 View commit details
    Browse the repository at this point in the history

  17. Don't pass unknown on* attributes through

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    5a339a1 View commit details
    Browse the repository at this point in the history

  18. Remove dead code

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    0b2ba65 View commit details
    Browse the repository at this point in the history

  19. Avoid accessing namespace when possible

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    3f85316 View commit details
    Browse the repository at this point in the history

  20. Drop .only in ReactDOMComponent-test

    @nhunzaker
    nhunzaker committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    76a6318 View commit details
    Browse the repository at this point in the history

  21. Make isCustomComponent logic more solid

    @gaearon
    gaearon committed Aug 29, 2017
    1 Configuration menu
    Copy the full SHA
    b29bb74 View commit details
    Browse the repository at this point in the history

  22. Do attribute name check earlier

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    0a2aec4 View commit details
    Browse the repository at this point in the history

  23. Fix fbjs import

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    501e86d View commit details
    Browse the repository at this point in the history

  24. Revert unintentional edit

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    8d1f487 View commit details
    Browse the repository at this point in the history

  25. Re-allow "data" attribute 

    We intentionally allowed it.
    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    72666fa View commit details
    Browse the repository at this point in the history

  26. Use stricter check when attaching events

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    cb687ed View commit details
    Browse the repository at this point in the history

  27. Pass SVG boolean attributes with correct casing

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    1d61379 View commit details
    Browse the repository at this point in the history

  28. Fix the test

    @gaearon
    gaearon committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    2b0f61a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2017

  1. Undo the SVG dashed-name fix 

    Per conversation with @sebmarkbage we decided that the fix is too complicated, and it's unfortunate it depends on the DOM element.
It's only relevant for super rare tags that aren't even working consistently across browsers so we'll leave it unfixed for now.
    @gaearon
    gaearon committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    1590c2a View commit details
    Browse the repository at this point in the history

  2. Prettier

    @gaearon
    gaearon committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    cb883a6 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @gaearon
    gaearon committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    32f6321 View commit details
    Browse the repository at this point in the history

  4. Fix flow

    @gaearon
    gaearon committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    6d9c0e0 View commit details
    Browse the repository at this point in the history

  5. Pass "aria" through but still warn

    @gaearon
    gaearon committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    10e0c09 View commit details
    Browse the repository at this point in the history

  6. Remove special cases for onfocusin, onfocusout 

    They're covered by event handler code now.
    @gaearon
    gaearon committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    ba71ec1 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2017

  1. Add a more specific warning for unknown events

    @gaearon
    gaearon committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    dc760af View commit details
    Browse the repository at this point in the history

  2. Pass badly cased React attributes through with warning

    @gaearon
    gaearon committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    10950c4 View commit details
    Browse the repository at this point in the history