Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose react-art/{Circle,Rectange/Wedge} on npm #11343

Merged
merged 3 commits into from
Oct 23, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 23, 2017

Fixes #11254.

Verified by looking into build folder:

screen shot 2017-10-23 at 17 07 58

screen shot 2017-10-23 at 17 08 02

and running updated fixture:

screen shot 2017-10-23 at 17 08 44

One thing I'm not super happy about it is we can't import them easily in tests. But I don't care tbqh.

Copy link
Contributor

@flarnie flarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goldfish_score

@gaearon gaearon merged commit f6c60dc into facebook:master Oct 23, 2017
@gaearon gaearon deleted the art-shapes branch October 23, 2017 18:18
Ethan-Arrowood pushed a commit to Ethan-Arrowood/react that referenced this pull request Dec 8, 2017
* Include ART shapes into npm package

* Fix the fixture

* Prettier oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-art on npm is missing the /lib/ folder
3 participants