New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about mistaken named / default export #11505

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@selbekk
Contributor

selbekk commented Nov 9, 2017

This commit adds a note about the possibility of erroneously
mistaking named and default exports to an existing error message.

Ref this issue.

@gaearon

Let's change "mistaken" to "mixed up". Seems better grammar-wise.

Kristofer Selbekk
Add note about mistaken named / default export
This commit adds a note about the possibility of erroneously
mistaking named and default exports to an existing error message.
@selbekk

This comment has been minimized.

Show comment
Hide comment
@selbekk

selbekk Nov 9, 2017

Contributor

I agree 👍

Contributor

selbekk commented Nov 9, 2017

I agree 👍

@gaearon

gaearon approved these changes Nov 9, 2017

@gaearon gaearon merged commit 5bfb878 into facebook:master Nov 9, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 9, 2017

Member

Very nice. Thank you.

Member

gaearon commented Nov 9, 2017

Very nice. Thank you.

@selbekk

This comment has been minimized.

Show comment
Hide comment
@selbekk

selbekk Nov 9, 2017

Contributor

No problem whatsoever :-)

Contributor

selbekk commented Nov 9, 2017

No problem whatsoever :-)

Ethan-Arrowood added a commit to Ethan-Arrowood/react that referenced this pull request Dec 8, 2017

Add note about mistaken named / default export (facebook#11505)
This commit adds a note about the possibility of erroneously
mistaking named and default exports to an existing error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment