New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfreeze the react-dom/server interface #11531

Merged
merged 4 commits into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@travi
Contributor

travi commented Nov 11, 2017

this allows stubbing of the exposed named functions, as was possible before v16.1

fixes #11526

@travi

This comment has been minimized.

Show comment
Hide comment
@travi

travi Nov 11, 2017

Contributor

i did see tests fail when the change was incomplete, so getting them passing again gives me as much confidence that this is completed successfully as i can get without deeper context of the project.

since this change should not change actual behaviors, it didn't seem appropriate to add any additional tests for this change, but if you'd like anything additional included with the change, just let me know.

Contributor

travi commented Nov 11, 2017

i did see tests fail when the change was incomplete, so getting them passing again gives me as much confidence that this is completed successfully as i can get without deeper context of the project.

since this change should not change actual behaviors, it didn't seem appropriate to add any additional tests for this change, but if you'd like anything additional included with the change, just let me know.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 12, 2017

Member

Have you verified this fixes your project?

Member

gaearon commented Nov 12, 2017

Have you verified this fixes your project?

@travi

This comment has been minimized.

Show comment
Hide comment
@travi

travi Nov 12, 2017

Contributor

Sorry, I should have included that, yes this does fix my project without any other modifications.

I'll get those comments included as soon as I'm back to a computer later today.

Contributor

travi commented Nov 12, 2017

Sorry, I should have included that, yes this does fix my project without any other modifications.

I'll get those comments included as soon as I'm back to a computer later today.

@travi

This comment has been minimized.

Show comment
Hide comment
@travi

travi Nov 12, 2017

Contributor

comments are added. let me know if you would like any wording tweaked

Contributor

travi commented Nov 12, 2017

comments are added. let me know if you would like any wording tweaked

Unfreeze the react-dom/server interface
this allows stubbing of the exposed named functions, as was possible before v16.1

fixes #11526

@facebook facebook deleted a comment from baby2girl Nov 13, 2017

gaearon added some commits Nov 13, 2017

@gaearon gaearon merged commit 901a091 into facebook:master Nov 13, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details

Ethan-Arrowood added a commit to Ethan-Arrowood/react that referenced this pull request Dec 8, 2017

Unfreeze the react-dom/server interface (facebook#11531)
* Unfreeze the react-dom/server interface

this allows stubbing of the exposed named functions, as was possible before v16.1

fixes facebook#11526

* Fix missing version export

* Fix missing version export

* Whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment