Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not for merge] Test Danger #12210

Closed
wants to merge 1 commit into from
Closed

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 11, 2018

No description provided.

@pull-bot
Copy link

Details of bundled changes.

Comparing: c7ce009...232208e

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -1% -1% 380.87 KB 380.87 KB 84.39 KB 84.39 KB UMD_DEV
react-art.production.min.js 🔺+1% 🔺+1% 84.77 KB 86.12 KB 26.31 KB 26.62 KB UMD_PROD
react-art.development.js -1% -1% 306.72 KB 306.72 KB 65.8 KB 65.8 KB NODE_DEV
react-art.production.min.js 🔺+2% 🔺+2% 49.56 KB 50.93 KB 15.63 KB 16.06 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -1% -1% 303.76 KB 303.76 KB 64.77 KB 64.77 KB NODE_DEV
react-test-renderer.production.min.js 🔺+2% 🔺+3% 48.07 KB 49.43 KB 14.96 KB 15.42 KB NODE_PROD

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer.development.js -1% 0% 18.34 KB 18.34 KB 5.18 KB 5.18 KB NODE_DEV
react-noop-renderer.production.min.js 🔺+8% 🔺+4% 6.28 KB 6.79 KB 2.51 KB 2.62 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -1% -1% 285.66 KB 285.66 KB 60.32 KB 60.31 KB NODE_DEV
react-reconciler.production.min.js 🔺+3% 🔺+2% 41.45 KB 42.82 KB 13.04 KB 13.4 KB NODE_PROD

Generated by 🚫 dangerJS

@gaearon gaearon closed this Feb 11, 2018
@gaearon
Copy link
Collaborator Author

gaearon commented Feb 11, 2018

@orta

It seems like react-dom change is unreported for some reason. Any ideas? I'm pretty sure this PR impacted react-dom, as seen on CI as well: https://circleci.com/gh/facebook/react/8925#tests/containers/2

@orta
Copy link
Contributor

orta commented Feb 12, 2018

Agree, looking now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants