Synchronously restart when an error is thrown during async rendering #13041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.2% Details of bundled changes.Comparing: 9bda7b2...7cffa51 react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
sebmarkbage
approved these changes
Jun 14, 2018
|
In a follow up we should see if we can only do the error replaying (invoke guarded callback) by reusing these two phases. The async phase only uses real try/catch. If it is a Promise, it'll catch it. If it is an error, it will always retry anyway. So the second one can only use invoke guarded callback. |
acdlite
force-pushed
the
restartonasyncerror
branch
from
1a236b0
to
f372e3a
Compare
In async mode, events are interleaved with rendering. If one of those events mutates state that is later accessed during render, it can lead to inconsistencies/tearing. Restarting the render from the root is often sufficient to fix the inconsistency. We'll flush the restart synchronously to prevent yet another mutation from happening during an interleaved event. We'll only restart during an async render. Sync renders are already sync, so there's no benefit in restarting. (Unless a mutation happens during the render phase, but we don't support that.)
acdlite
force-pushed
the
restartonasyncerror
branch
from
f372e3a
to
7cffa51
Compare
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jun 15, 2018
Since facebook#13041, we always replay the entire render phase before handling an error. We can wrap this in invokeGuardedCallback, instead of wrapping and replaying only the render phase of the failed fiber. Now we don't have to stash the work-in-progress fiber fields, which was quite fragile.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jun 15, 2018
Since facebook#13041, we always replay the entire render phase before handling an error. We can wrap this in invokeGuardedCallback, instead of wrapping and replaying only the render phase of the failed fiber. Now we don't have to stash the work-in-progress fiber fields, which was quite fragile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In async mode, events are interleaved with rendering. If one of those events mutates state that is later accessed during render, it can lead to inconsistencies/tearing.
Restarting the render from the root is often sufficient to fix the inconsistency. We'll flush the restart synchronously to prevent yet another mutation from happening during an interleaved event.
We'll only restart during an async render. Sync renders are already sync, so there's no benefit in restarting. (Unless a mutation happens during the render phase, but we don't support that.)