Do not add additional work to a batch that is already rendering #13072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Details of bundled changes.Comparing: 4fe6eec...4be858d react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
sebmarkbage
approved these changes
Jun 19, 2018
| @@ -1086,6 +1086,8 @@ function renderRoot(root: FiberRoot, isYieldy: boolean): void { | |||
| if (__DEV__) { | |||
| resetStackAfterFatalErrorInDev(); | |||
| } | |||
| // Clear the currently rendering root. | |||
There was a problem hiding this comment.
These comments are not helpful. Obviously you're clearing the root based on the next line. Say why, not what you're doing.
There was a problem hiding this comment.
E.g. "By clearing the root, we force React to start over by rendering the root from scratch instead of continuing in the middle of the tree. We have to do that because we've added new work to the tree and that might otherwise be inconsistent depending on where we are in the current render."
There was a problem hiding this comment.
Ok Seb, I know what a comment is. Thanks for the explanation.
There was a problem hiding this comment.
"Better comment, please" would have sufficed
acdlite
force-pushed
the
dontaddtoalreadyrenderingbatch
branch
from
92e981c
to
dfcbfa7
Compare
Otherwise, the part of the tree that hasn't rendered yet will receive the latest state, but the already rendered part will show the state as it was before the intervening update.
acdlite
force-pushed
the
dontaddtoalreadyrenderingbatch
branch
from
dfcbfa7
to
4be858d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #13071
Otherwise, the part of the tree that hasn't rendered yet will receive the latest state, but the already rendered part will show the state as it was before the intervening update.