Remove 'warning' module from the JS scheduler #13264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** See title **why make this change?:** Internally the 'warning' module has some dependencies which we want to avoid pulling in during the very early stages of initial pageload. It is creating a cyclical dependency. And we wanted to remove this dependency anyway, because this module should be kept small and decoupled. **test plan:** - Tested the exact same change internally in Facebook.com - Ran unit tests - Tried out the fixture **issue:** Internal task T31831021
|
Another alternative is to move the polyfill check up into React, but seems like it makes sense to bake that in imo. Because the schedule module won't work without rAF, and it will eventually be available without React. |
Details of bundled changes.Comparing: ca0941f...da1873a react-scheduler
Generated by 🚫 dangerJS |
|
Should we keep this check? |
gaearon
approved these changes
Jul 25, 2018
| 'Make sure that you load a ' + | ||
| 'polyfill in older browsers. https://fb.me/react-polyfills', | ||
| ); | ||
| if (__DEV__ && typeof console !== 'undefined') { |
There was a problem hiding this comment.
Nit: we tend to put DEV check in its own separate if block, and then nest another if (when necessary). Makes DEV conditions stand out more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
See title
why make this change?:
Internally the 'warning' module has some dependencies which we want to
avoid pulling in during the very early stages of initial pageload. It is
creating a cyclical dependency.
And we wanted to remove this dependency anyway, because this module
should be kept small and decoupled.
test plan:
issue:
Internal task T31831021
Before submitting a pull request, please make sure the following is done:
master.yarnin the repository root.yarn test). Tip:yarn test --watch TestNameis helpful in development.yarn test-prodto test in the production environment. It supports the same options asyarn test.yarn debug-test --watch TestName, openchrome://inspect, and press "Inspect".yarn prettier).yarn lint). Tip:yarn lincto only check changed files.yarn flow).Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html