Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor validateDOMNesting a bit #13300

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Refactor validateDOMNesting a bit #13300

merged 1 commit into from
Aug 1, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 1, 2018

Very minor cleanup.

  • Use named exports instead of attaching one function to another
  • Remove unused argument/field from the Stack era

@gaearon gaearon requested a review from bvaughn August 1, 2018 15:19
@gaearon gaearon requested a review from flarnie August 1, 2018 15:19
@pull-bot
Copy link

pull-bot commented Aug 1, 2018

Details of bundled changes.

Comparing: 0182a74...2e0926c

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.0% -0.0% 641.57 KB 641.3 KB 150.53 KB 150.46 KB UMD_DEV
react-dom.development.js -0.0% -0.0% 637.71 KB 637.44 KB 149.34 KB 149.28 KB NODE_DEV
ReactDOM-dev.js -0.0% -0.0% 644.9 KB 644.58 KB 147.67 KB 147.61 KB FB_WWW_DEV

Generated by 🚫 dangerJS

@gaearon gaearon requested a review from trueadm August 1, 2018 15:33
@gaearon gaearon merged commit 28cd494 into facebook:master Aug 1, 2018
segoddnja pushed a commit to segoddnja/react that referenced this pull request Aug 1, 2018
@gaearon @segoddnja
Refactor validateDOMNesting a bit (facebook#13300)
23d3ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

@flarnie flarnie Awaiting requested review from flarnie

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaearon @pull-bot @trueadm @facebook-github-bot