Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test-renderer tests for suspense + flushSync [WIP] #13682

Closed
wants to merge 1 commit into from
Closed

Add test-renderer tests for suspense + flushSync [WIP] #13682

wants to merge 1 commit into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 18, 2018 •
edited
Loading

I noticed that the test renderer's unstable_flushSync doesn't work correctly with setState and suspense, so I added some tests (one failing) to cover this. Fix to follow...

@sizebot
Copy link

sizebot commented Sep 18, 2018

Details of bundled changes.

Comparing: 9b70816...dbd8cda

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@klamping klamping mentioned this pull request Sep 18, 2018
Open
@necolas necolas added the React Core Team Opened by a member of the React Core Team label Jan 8, 2020
@bvaughn bvaughn closed this Jan 23, 2020
@bvaughn bvaughn deleted the test-renderer-flush-sync branch January 23, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvaughn @sizebot @necolas @facebook-github-bot