-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSR support for class contextType #13889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
commented
Oct 19, 2018
@@ -516,7 +518,7 @@ function constructClassInstance( | |||
if (typeof contextType === 'object' && contextType !== null) { | |||
if (__DEV__) { | |||
if ( | |||
contextType.Consumer === undefined && | |||
contextType.$$typeof !== REACT_CONTEXT_TYPE && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus fix. Better feature test.
Details of bundled changes.Comparing: fa65c58...82c6f56 react-dom
scheduler
Generated by 🚫 dangerJS |
acdlite
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the CI failures
sebmarkbage
force-pushed
the
ssrcontexttype
branch
from
October 19, 2018 17:33
2c982fa
to
98c5182
Compare
sebmarkbage
force-pushed
the
ssrcontexttype
branch
from
October 19, 2018 18:02
98c5182
to
82c6f56
Compare
linjiajian999
pushed a commit
to linjiajian999/react
that referenced
this pull request
Oct 22, 2018
Merged
This was referenced Oct 24, 2018
This was referenced Nov 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work by @alexmckenley