-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak error message for missing fallback #14068
Conversation
I should try to include the component stack. |
ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.3% Details of bundled changes.Comparing: 595b4f9...5c1a324 react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
scheduler
Generated by 🚫 dangerJS |
Maybe we can get rid of the passive voice while we're at it. Alt suggestion:
|
How's this. |
e791570
to
4b0062a
Compare
@@ -315,8 +316,14 @@ function throwException( | |||
workInProgress = workInProgress.return; | |||
} while (workInProgress !== null); | |||
// No boundary was found. Fallthrough to error mode. | |||
// TODO: Use invariant so the message is stripped in prod? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I originally used invariant inside a try/catch but @sebmarkbage said we should fix our error extraction script to work on Error instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seemsreasonable
4b0062a
to
5c1a324
Compare
No description provided.