Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak error message for missing fallback #14068

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Tweak error message for missing fallback #14068

merged 1 commit into from
Nov 2, 2018

Conversation

sophiebits
Copy link
Collaborator

No description provided.

@sophiebits
Copy link
Collaborator Author

I should try to include the component stack.

@sizebot
Copy link

sizebot commented Nov 2, 2018 •
edited
Loading

ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.3%

Details of bundled changes.

Comparing: 595b4f9...5c1a324

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% +0.1% 703.61 KB 703.95 KB 162.94 KB 163.04 KB UMD_DEV
react-dom.production.min.js 🔺+0.2% 🔺+0.3% 102.41 KB 102.57 KB 33.48 KB 33.57 KB UMD_PROD
react-dom.development.js 0.0% +0.1% 698.92 KB 699.26 KB 161.57 KB 161.67 KB NODE_DEV
react-dom.production.min.js 🔺+0.2% 🔺+0.3% 102.5 KB 102.66 KB 32.99 KB 33.1 KB NODE_PROD
ReactDOM-dev.js +0.1% +0.1% 717.18 KB 717.58 KB 162.4 KB 162.5 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.2% 310.07 KB 310.45 KB 57.23 KB 57.36 KB FB_WWW_PROD
react-dom.profiling.min.js +0.2% +0.3% 104.87 KB 105.04 KB 33.32 KB 33.41 KB NODE_PROFILING
ReactDOM-profiling.js +0.1% +0.2% 314.4 KB 314.71 KB 58.15 KB 58.25 KB FB_WWW_PROFILING
react-dom.profiling.min.js +0.2% +0.3% 104.74 KB 104.91 KB 33.82 KB 33.9 KB UMD_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 490.74 KB 491.07 KB 108.68 KB 108.79 KB UMD_DEV
react-art.production.min.js 🔺+0.2% 🔺+0.3% 94.29 KB 94.46 KB 29.11 KB 29.19 KB UMD_PROD
react-art.development.js +0.1% +0.1% 422.52 KB 422.86 KB 91.66 KB 91.77 KB NODE_DEV
react-art.production.min.js 🔺+0.3% 🔺+0.6% 59.33 KB 59.5 KB 18.38 KB 18.49 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 427.12 KB 427.51 KB 90.21 KB 90.31 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.4% 183.22 KB 183.6 KB 31.37 KB 31.49 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 435.16 KB 435.5 KB 94.33 KB 94.44 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.3% 🔺+0.5% 60.52 KB 60.69 KB 18.8 KB 18.88 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 430.38 KB 430.72 KB 93.18 KB 93.29 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.3% 🔺+0.5% 60.21 KB 60.37 KB 18.55 KB 18.64 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 435.17 KB 435.56 KB 92.08 KB 92.17 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.1% 420.36 KB 420.71 KB 90.1 KB 90.21 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.3% 🔺+0.6% 60.55 KB 60.71 KB 18.18 KB 18.28 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% +0.1% 418.81 KB 419.15 KB 89.48 KB 89.58 KB NODE_DEV
react-reconciler-persistent.production.min.js 🔺+0.3% 🔺+0.6% 60.56 KB 60.72 KB 18.18 KB 18.29 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 553.4 KB 553.79 KB 121.03 KB 121.15 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.2% 🔺+0.3% 238.11 KB 238.5 KB 41.9 KB 42.03 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.1% +0.1% 553.07 KB 553.46 KB 120.93 KB 121.04 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 🔺+0.2% 🔺+0.3% 238.13 KB 238.51 KB 41.9 KB 42.03 KB RN_OSS_PROD
ReactFabric-dev.js +0.1% +0.1% 543.59 KB 543.98 KB 118.57 KB 118.68 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.2% 🔺+0.2% 233 KB 233.38 KB 40.63 KB 40.73 KB RN_FB_PROD
ReactFabric-dev.js +0.1% +0.1% 543.62 KB 544.01 KB 118.59 KB 118.69 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+0.2% 🔺+0.2% 233.03 KB 233.42 KB 40.64 KB 40.74 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% +0.2% 243.9 KB 244.21 KB 43.13 KB 43.22 KB RN_OSS_PROFILING
ReactFabric-profiling.js +0.1% +0.2% 237.65 KB 237.96 KB 41.9 KB 41.99 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js +0.1% +0.2% 243.88 KB 244.19 KB 43.13 KB 43.23 KB RN_FB_PROFILING
ReactFabric-profiling.js +0.1% +0.2% 237.61 KB 237.92 KB 41.89 KB 41.98 KB RN_FB_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@acdlite
Copy link
Collaborator

acdlite commented Nov 2, 2018

Maybe we can get rid of the passive voice while we're at it.

Alt suggestion:

ComponentName suspended while rendering, but React doesn't know what to render in its place. Add <Suspense fallback=... /> somewhere higher in the tree.

@sophiebits
Copy link
Collaborator Author

How's this.

@sophiebits sophiebits force-pushed the suspense-err branch 2 times, most recently from e791570 to 4b0062a Compare November 2, 2018 01:06
acdlite
acdlite reviewed Nov 2, 2018
View reviewed changes
packages/react-reconciler/src/ReactFiberUnwindWork.js
@@ -315,8 +316,14 @@ function throwException(
workInProgress = workInProgress.return;
} while (workInProgress !== null);
// No boundary was found. Fallthrough to error mode.
// TODO: Use invariant so the message is stripped in prod?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I originally used invariant inside a try/catch but @sebmarkbage said we should fix our error extraction script to work on Error instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seemsreasonable

@sophiebits sophiebits merged commit c84b9bf into facebook:master Nov 2, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@sophiebits @jetoneza
Tweak error message for missing fallback (facebook#14068)
e781c57
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@sophiebits @n8schloss
Tweak error message for missing fallback (facebook#14068)
c302f06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophiebits @sizebot @acdlite @facebook-github-bot