Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hooks in fabric #14301

Merged
merged 1 commit into from Dec 5, 2018
Merged

Enable hooks in fabric #14301

merged 1 commit into from Dec 5, 2018

Conversation

sahrens
Copy link
Contributor

@sahrens sahrens commented Nov 22, 2018

because hooks are awesome.

because hooks are awesome.
@sizebot
Copy link

sizebot commented Nov 22, 2018

Details of bundled changes.

Comparing: a9fdf8a...862386b

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js -0.0% 0.0% 553.1 KB 553.1 KB 119.93 KB 119.93 KB RN_FB_DEV
ReactFabric-prod.js 🔺+6.9% 🔺+8.3% 218.37 KB 233.41 KB 37.63 KB 40.76 KB RN_FB_PROD
ReactFabric-profiling.js +6.8% +7.9% 223.12 KB 238.37 KB 39.04 KB 42.11 KB RN_FB_PROFILING

Generated by 🚫 dangerJS

@brunolemos
Copy link

brunolemos commented Nov 22, 2018

Have the issues been fixed? E.g. the useEffect delay.

EDIT: They have now

@sebmarkbage sebmarkbage merged commit 39489e7 into facebook:master Dec 5, 2018
trueadm pushed a commit to trueadm/react that referenced this pull request Dec 14, 2018
because hooks are awesome.
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
because hooks are awesome.
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
because hooks are awesome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants