Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帲 Using React Hooks in React Native #21967

Closed
theluk opened this issue Oct 26, 2018 · 133 comments
Closed

馃帲 Using React Hooks in React Native #21967

theluk opened this issue Oct 26, 2018 · 133 comments

Comments

@theluk
Copy link

@theluk theluk commented Oct 26, 2018

React Hooks will ship as part of React Native 0.59.

If you are interested in using Hooks before then, see my comment below.

Original issue:

Environment

[skip envinfo]
OS: Windows 10
Node: 10.11.0
Yarn: Not Found
npm: 6.4.1
Watchman: Not Found
Xcode: N/A
Android Studio: Version 3.2.0.0 AI-181.5540.7.32.5056338

Packages: (wanted => installed)
react: 16.7.0-alpha.0 => 16.7.0-alpha.0
react-native: https://github.com/expo/react-native/archive/sdk-30.0.0.tar.gz => 0.55.4
expo: 2.2.0

Description

When using React Hooks like useState within a function component, I get the following error message.

hooks can only be called inside the body of a function component

export default function RootContainer(props) {
  const [something, setSomething] = useState('nothing');

  return (
    <View />
  );
};
@react-native-bot

This comment has been hidden.

@brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Oct 27, 2018

I was not able to make it work on react-native as well, but with a different error:

TypeError: dispatcher.useState is not a function

hooks can only be called inside the body of a function component

I noticed that this error also happens when you have two different instances of React being used, so double check that. (facebook/react#13991)

@chrisbianca
Copy link

@chrisbianca chrisbianca commented Oct 27, 2018

I started looking into this yesterday and it seems that the React Native renderer needs to be updated to implement something similar to what has been added for React Dom: https://github.com/facebook/react/pull/13968/files#diff-72f7665306d50674917de18af012bc5b

Currently the React Native renderer only exports the readContext method on it's Dispatcher: https://github.com/facebook/react-native/blob/master/Libraries/Renderer/oss/ReactNativeRenderer-dev.js#L13485

I didn't look into the actual implementation details to see whether this is an easy port as it looks like there's multiple versions of the renderers - both the current and Fabric version of the renderer have a dev, prod and profiling version. I'm assuming these are generated in some way from a single base file for each version (current / Fabric) which isn't available in the repo.

@developer239
Copy link

@developer239 developer239 commented Oct 27, 2018

馃槩馃槶

@hramos
Copy link
Contributor

@hramos hramos commented Oct 28, 2018

We need to update the React Native Renderer inside the Libraries/Renderer directory alongside the React dependency. Please wait for the React sync to land, and we will cut a new official release with 16.6 then. We鈥檒l do the same once 16.7 stable is released.

@brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Oct 28, 2018

We鈥檒l do the same once 16.7 stable is released.

It would be much appreciated to have a next version of react-native synced with the next version of react so we can try hooks, concurrent and any other new feature together with everyone else.

My project is universal (same components between web and mobile) so my hands are tied. Can't use hooks or simply upgrade because react-native breaks.

@gaearon
Copy link
Member

@gaearon gaearon commented Oct 28, 2018

We can just do a sync with enableHooks: false feature flag and then those who want can override it locally.

@ferrannp
Copy link
Contributor

@ferrannp ferrannp commented Oct 29, 2018

We鈥檒l do the same once 16.7 stable is released.

@hramos React team ask to the community to try hooks and give feedback about them. IMO we need a way for RN people to be able to provide this feedback too (not only React projects) before anything is stable.

@fungilation
Copy link

@fungilation fungilation commented Oct 29, 2018

Hooks is quite a change for React / RN syntax. A lot of docs will need updating too?

@hramos
Copy link
Contributor

@hramos hramos commented Oct 29, 2018

Using Hooks in React Native

If you'd like to try out Hooks today, you can do the following after installing React 16.7.0-alpha in your project:

Note: Hooks are an experimental proposal to React. You can learn more in @gaearon's post, Making Sense of React Hooks.

  1. Clone the https://github.com/facebook/react repository.
  2. Navigate to the react directory.
  3. Replace all instances of enableHooks = false with enableHooks = true in packages/shared.
  4. Run yarn install
  5. Run yarn build -- --type=RN_OSS.
  6. After a few seconds, you'll notice a new build/react-native/ directory has been created. Copy the contents of this directory, to your project's node_modules/react-native/Libraries/Renderer directory.

Let us know if the above steps work out for you.


We're planning on landing support for React 16.6.0 in 0.57.5. Hooks is available in the 16.7.0-alpha, and feedback from the community so far has been that upgrading to alphas of React in the stable React Native releases can be disruptive. What do people here think about a React Native 0.57.5-alpha release that includes support for 16.7.0-alpha out of the box?

@hramos hramos changed the title React Hooks not working Using React Hooks in React Native Oct 29, 2018
@dabit3
Copy link
Contributor

@dabit3 dabit3 commented Oct 30, 2018

Thanks @hramos for this info! So this works fine when using useState, but for some reason when I move on to try useEffect I get the following error:

failed to execute 'postMessage' on 'DedicatedWorkerGlobalScope': No function was found that matched the signature provided.

Any ideas on what could be causing this or how to mitigate?

UPDATE This only throws when remote debugger is enabled.

@jlongster
Copy link

@jlongster jlongster commented Oct 30, 2018

Wouldn't it be something like a 0.57.6-alpha if you're already aiming for a stable 0.57.5?

I'm totally fine using a custom build for React Native, as long as it works. Haven't tried it yet but does the error in the above comment make sense? If it helps I can try it as well.

@Manishalexin
Copy link

@Manishalexin Manishalexin commented Oct 30, 2018

Thanks @hramos for this info! So this works fine when using useState, but for some reason when I move on to try useEffect I get the following error:

failed to execute 'postMessage' on 'DedicatedWorkerGlobalScope': No function was found that matched the signature provided.

Any ideas on what could be causing this or how to mitigate?

I was able to use useEffect without any issues. Anything in particular that didn't work with useEffect?

@dabit3
Copy link
Contributor

@dabit3 dabit3 commented Oct 30, 2018

@Manishalexin Just tried it again with a completely new build, still not working for me.

I've tried useEffect in a couple of different ways, still getting errors on all of them (same error as above).

React Native Environment Info:
    System:
      OS: macOS Sierra 10.12.6
      CPU: x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
      Memory: 52.84 MB / 8.00 GB
      Shell: 5.2 - /bin/zsh
    Binaries:
      Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
      Yarn: 1.3.2 - /usr/local/bin/yarn
      npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
    SDKs:
      iOS SDK:
        Platforms: iOS 11.2, macOS 10.13, tvOS 11.2, watchOS 4.2
      Android SDK:
        Build Tools: 23.0.1, 26.0.1, 26.0.2, 26.0.3, 27.0.3
        API Levels: 23, 26, 27
    IDEs:
      Android Studio: 3.0 AI-171.4443003
      Xcode: 9.2/9C40b - /usr/bin/xcodebuild
    npmPackages:
      react: ^16.7.0-alpha.0 => 16.7.0-alpha.0
      react-native: 0.57.4 => 0.57.4
    npmGlobalPackages:
      react-native-cli: 2.0.1

UPDATE This only throws when remote debugger is enabled.

@Manishalexin
Copy link

@Manishalexin Manishalexin commented Oct 30, 2018

@dabit3 I have the exact same config for npm modules but system-wise I am Mojave and Xcode 12( Shouldn't matter, I presume). And moreover, the error seems service worker related. ( which is weird in vanilla RN project )
I'll quickly try with a fresh project and report back. ( I tried it with an existing project )

@dabit3
Copy link
Contributor

@dabit3 dabit3 commented Oct 30, 2018

@Manishalexin did you see my comment about the remote debugger?

@Manishalexin
Copy link

@Manishalexin Manishalexin commented Oct 30, 2018

@dabit3 Just saw. ( Comment doesn't update till page refresh ).
Can confirm the issue with my build too.

UPDATE: @dabit3 Although we get the error, it still works and the app is connected to the debugger and everything else works as expected if we ignore the error and dismiss the error screen.
(Seems to be just an uncaught error on the func signature def )

@IljaDaderko
Copy link
Contributor

@IljaDaderko IljaDaderko commented Oct 30, 2018

@hramos Regarding your question of using react alpha in react-native: I am usually freakishly strict about using unstable versions of packages in my projects, but having played with 16.7 alpha this weekend I didn't notice any bugs.

Perhaps an alpha release of react-native including hooks could be a good idea? I assume if hooks go past RFC stage and get implemented, react-native will need a lot of pre-testing and this seems like a feature that people would actually love to start using and testing as early as now?

@jfrolich
Copy link

@jfrolich jfrolich commented Oct 30, 2018

An alpha release of react-native would be awesome! I am working on a new app that isn't published yet, and would love to use the new hooks API.

@chrisbianca
Copy link

@chrisbianca chrisbianca commented Oct 30, 2018

We're planning on landing support for React 16.6.0 in 0.57.5. Hooks is available in the 16.7.0-alpha, and feedback from the community so far has been that upgrading to alphas of React in the stable React Native releases can be disruptive. What do people here think about a React Native 0.57.5-alpha release that includes support for 16.7.0-alpha out of the box?

I think letting people opt in to the React 16.7.0-alpha by way of an alpha release of RN is a great idea.

I've certainly struggled in the past with seeing alpha or even beta releases of React being included as part of a stable React Native release and would find it hard to justify in a more corporate environment. However, for those people who are more adventurous, allowing access to it as an alpha release gives people the best of both worlds.

@hramos
Copy link
Contributor

@hramos hramos commented Oct 30, 2018

We've been discussing with other core contributors how to best approach this, and we're currently leaning towards focusing on landing support for React 16.6.0 stable on React Native 0.57.5 first. We're expecting 0.57.5 to be released sometime this week.

Once that happens, people who would like to experiment with React Hooks may opt to install the React 16.7.0.alpha on their project and follow the instructions I posted earlier to sync the React Native Renderer with Hooks support to their project.

As React Hooks is expected to remain experimental for a few more months, we believe this approach provides the right mix of allowing you all to opt into React Hooks, without placing additional strain on the release process for the next few months prior to React Hooks potentially reaching stable release status.

@jfrolich
Copy link

@jfrolich jfrolich commented Oct 31, 2018

Did someone in the community that followed these steps already publish a temporary package to NPM containing the alpha? Would make it easier for us to try it out by just aliasing. If not, anyone interested in it here? then I鈥檒l try to publish!

@Foveluy
Copy link

@Foveluy Foveluy commented Nov 2, 2018

For anyone who suffers from building react-native-renderer, i have done a repo to for it, just download and copy it by following
this instructions , you can play with hooks.

https://github.com/Foveluy/rn-temp-renderer

Edit

it doesn't work after copy those file into renderers.

hooks can only be called inside the body of a function component
@brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Dec 22, 2018

@davibe I haven't tried my fork on expo, try this https://github.com/expo/sdk-31-with-hooks-experimental

@elkevinwolf
Copy link

@elkevinwolf elkevinwolf commented Dec 22, 2018

I can confirm @brunolemos fork is working with Expo.

@brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Dec 23, 2018

Instead of using react@next or ^16.7.0-alpha-2, now you need to use the exact version 16.7.0-alpha-2 (without the ^).

This is because 16.7.0 was recently released without hooks and your npm/yarn may be resolving to it.

@pabloobandodev
Copy link

@pabloobandodev pabloobandodev commented Dec 27, 2018

Hooks es un gran cambio para la sintaxis React / RN. 驴Una gran cantidad de documentos necesitar谩n una actualizaci贸n tambi茅n?

It is optional to implement it because imagine that Hooks is a functional component with access to the state, to the life cycle, to the context. It is a "class with a wrapped in a functional component". The classes are not going to disappear or the functional components, now we have an easier way to use what the class provided us and to reuse logic.

@chinds185a
Copy link

@chinds185a chinds185a commented Dec 31, 2018

Wonder if anyone can help, I have followed @brunolemos guide on getting up and running with hooks on react-native, but as soon as I start to use hooks in my project I run into this error in the android simulator;

image

package.json

"dependencies": {
    "firebase": "^5.7.0",
    "jsc-android": "236355.1.1",
    "native-base": "^2.8.1",
    "react": "^16.7.0-alpha.2",
    "react-native": "npm:@brunolemos/react-native",
    "react-native-gesture-handler": "^1.0.12",
    "react-native-vector-icons": "^6.1.0",
    "react-navigation": "^3.0.8"
  },
  "devDependencies": {
    "@types/react": "^16.7.18",
    "@types/react-native": "^0.57.24",
    "babel-jest": "23.6.0",
    "jest": "23.6.0",
    "metro-react-native-babel-preset": "0.48.5",
    "react-test-renderer": "16.7.0-alpha.2"
  },

Updating to babel 7 and adding

import "core-js/es6/symbol";
import "core-js/fn/symbol/iterator";

as polyfills didn't work either

Edit: Now getting;

image

Edit (again). Was something not installing the alpha.2 of react. That is now fixed but now getting this error

image

Edit: Back to where I started earlier

image

@brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Jan 1, 2019

@chinds185a I'm assuming you already did this: #21967 (comment)

And followed the upgrade guide of each react native version after the one you were using.

Upgrade your metro-react-native-babel-preset version. Change your .babelrc to this https://github.com/devhubapp/devhub/blob/master/.babelrc.

It seems you are using custom jsc. Remove the polyfills, make sure you followed the steps correctly: https://github.com/react-native-community/jsc-android-buildscripts/blob/master/README.md#how-to-use-it-with-my-react-native-app

@chinds185a
Copy link

@chinds185a chinds185a commented Jan 1, 2019

Thanks for the suggestions @brunolemos will try these later.

I haven鈥檛 followed the upgrade path as this is a new project and I started with the latest versions of react and react-native.

@chinds185a
Copy link

@chinds185a chinds185a commented Jan 1, 2019

@brunolemos Thanks for the suggestions however I am still having the same issues, and it only appears when trying the useContext hook :/

I have;

  • Removed the polyfills
  • Locked react version too 16.7.0-alpha.2
  • Updated metro-react-native-babel-preset to ^0.51.1
    • Setup .bablerc accordingly
  • Using the latest JSC for android and followed the setup/build instructions
  • I am running babel 7
  • Have react-native installed from npm:@brunolemos/react-native
@rmilejcz
Copy link

@rmilejcz rmilejcz commented Jan 14, 2019

@chinds185a is your package.json the same as you previously posted? You need to remove the caret from ^16.7.0-alpha.2, it should be 16.7.0-alpha.2 instead since 16.7.0 is officially released. Might also be a good idea to delete node_modules and then reinstall

@gazedash
Copy link

@gazedash gazedash commented Jan 17, 2019

Any estimate about the date when hooks will be ready to use with RN in production? I mean, using stable version, not alphas and betas

@pvinis
Copy link
Contributor

@pvinis pvinis commented Jan 17, 2019

I think it should be this coming 0.58 right?

@sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented Jan 17, 2019

They will only publish stable versions with stable react versions from now on. So you may wait till hooks reach a stable version in the upstream react library, which should happen within a few months.

@rmilejcz
Copy link

@rmilejcz rmilejcz commented Jan 17, 2019

@pvinis I doubt it.

@gazedash 0.58 will probably ship with react 16.7 as a dependency, which does not include support for hooks unfortunately. Ideally, 16.8 will include support for hooks, and hopefully we can see that by react-native 0.60. For now we'll just have to accept that hooks are an experimental feature in react so using them is gonna take a bit of legwork

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 17, 2019

The above replies are correct!

We (React core team) haven't announced the date when hooks will be released in a stable React version鈥 (other than saying "soon")鈥 and this is a prerequisite for supporting hooks in React Native.

I will say that as soon as hooks are released in React stable, I'll be working with the React Native team to unblock anything needed to support hooks there. I'm already working on upgrading ancillary packages (like the standalone react-devtools) in preparation.

@aleclarson
Copy link
Contributor

@aleclarson aleclarson commented Jan 24, 2019

@bvaughn Are there large changes required for React Native to support hooks, or is it pretty basic stuff? I'm using ptmt/react-native-macos, and I'm considering using React hooks in my codebase, even if that means making some changes to native code.

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 24, 2019

There might some unknowns but I don't think it should be large, no.

@hramos
Copy link
Contributor

@hramos hramos commented Jan 24, 2019

For those asking for a timeline, support for Hooks in RN should land no earlier than Release 0.60. This is based on the fact the 0.59 RC is due to be cut soon, with React 16.6.3 as a dependency most likely.

@fbartho
Copy link
Contributor

@fbartho fbartho commented Jan 24, 2019

Oh no鈥硷笍 鉂わ笍 hooks, is there anywhere where we can beg to get hooks into 59? @hramos

@hramos
Copy link
Contributor

@hramos hramos commented Jan 24, 2019

The 0.59 release is being coordinated in react-native-community/releases#79, and that's the best place to discuss if you feel strongly that this cannot wait for 0.60.

@kelset
Copy link
Collaborator

@kelset kelset commented Jan 28, 2019

If you want a more in depth explanation of what it takes for Hooks to land: react-native-community/releases#79 (comment)

(locking to keep this as last link until updates)

@facebook facebook locked as resolved and limited conversation to collaborators Jan 28, 2019
@hramos
Copy link
Contributor

@hramos hramos commented Feb 6, 2019

React 16.8 with Hooks has been released: https://reactjs.org/blog/2019/02/06/react-v16.8.0.html

We are working on updating React Native to use React 16.8 in time for the React Native 0.59 release.

@hramos
Copy link
Contributor

@hramos hramos commented Feb 8, 2019

馃憖 ccefc70

Hooks have landed in React Native. They will be part of the 0.59 release.

@cpojer cpojer closed this Feb 11, 2019
@kelset kelset changed the title Using React Hooks in React Native 馃帲 Using React Hooks in React Native Feb 21, 2019
@hramos
Copy link
Contributor

@hramos hramos commented Mar 12, 2019

The 0.59 release has been promoted to stable. Read more in the React Native blog: http://facebook.github.io/react-native/blog/2019/03/12/releasing-react-native-059

Now that Hooks are generally available, I'll go ahead and unpin this thread.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet