-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fire] Add initial build infrastructure #14359
Conversation
Details of bundled changes.Comparing: d14ba87...f8e8430 react-dom
Generated by 🚫 dangerJS |
Looks good – we also need a ReactFire specific ReactFlag if possible, like I've done in https://github.com/trueadm/react/tree/react-dom-fire so we can disable some legacy tests around thing we no longer support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Let's do together with main integration PR. |
So where did we land on the versioning here? We should be clear so that if someone has to do a patch release, they know what to do. |
Let's call next a minor. reactjs/react.dev#1447 |
(Which probably means you should land yours too?) |
This adds:
react-dom/unstable-fire
entry pointreact-dom/src/fire
folder which is where we'll put the implementation filesreact-dom/src/fire/ReactFireHostConfig
. Currently it just re-exports the old one, but you can verify it works by uncommenting theconsole.log
in there.bundles.js
,forks.js
, and a new inlining aliasreact-reconciler/inline.fire
for our host config. This also means there'syarn flow fire
now.react-dom/src/fire/ReactFire
. It is a copy-paste ofReactDOM
entry point with fixed relative paths. Its main purpose it just to show that the setup works — we'll fully replace the actual content later. Importantly, it referencesreact-reconciler/inline.fire
.yarn test-fire
andyarn test-fire-prod
now stubsreact-dom
withreact-dom/unstable-fire
. You can verify this by commenting outconsole.log
s in the Fire host config and in the Fire entry point.yarn build react/index,fire --type=UMD_DEV
.After this PR is merged we can rebase @trueadm's initial work on top.
Note: I decided to go with
ReactFire
rather thanReactDOMFire
because we already know it's DOM and Dominic feels it's already getting too verbose for his taste. :P