Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMark Profiler API as stable #15172
+128
−132
Conversation
bvaughn
requested a review
from sebmarkbage
Mar 20, 2019
facebook-github-bot
added
the
CLA Signed
label
Mar 20, 2019
This comment has been minimized.
This comment has been minimized.
|
|
bvaughn
merged commit 56035da
into
facebook:master
Mar 21, 2019
1 check passed
ci/circleci
Your tests passed on CircleCI!
Details
bvaughn
deleted the
bvaughn:stable-Profiler
branch
Mar 21, 2019
This comment has been minimized.
This comment has been minimized.
markerikson
commented
Mar 22, 2019
|
Per my comment on Twitter the other day, it would be nice to have metrics for commit times too (especially if sync |
This comment has been minimized.
This comment has been minimized.
|
Awesome! Did this land in 16.8.5? |
This comment has been minimized.
This comment has been minimized.
|
No, 16.9 |
This comment has been minimized.
This comment has been minimized.
|
Oh, nice. Good to know. Thanks! |
Kiku-Reise
added a commit
to Kiku-Reise/react
that referenced
this pull request
May 16, 2019
Merged
This was referenced Aug 17, 2019
This was referenced Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bvaughn commentedMar 20, 2019
•
edited
The
ProfilerRFC (reactjs/rfcs#51) is 10 months old and API hasn't changed in months. It seems like that we'll want to add a new API forSuspensemetrics, but as a new prop that should not impact the existingonRenderprop.Maybe it's time to mark this API as stable? Opening for discussion purposes.
(If this lands, I will update and close out the RFC.)