Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Profiler API as stable #15172

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@bvaughn
Copy link
Contributor

commented Mar 20, 2019

The Profiler RFC (reactjs/rfcs#51) is 10 months old and API hasn't changed in months. It seems like that we'll want to add a new API for Suspense metrics, but as a new prop that should not impact the existing onRender prop.

Maybe it's time to mark this API as stable? Opening for discussion purposes.

(If this lands, I will update and close out the RFC.)

@threepointone
Copy link
Contributor

left a comment

👣ship itttt

@bvaughn

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

❤️

@bvaughn bvaughn merged commit 56035da into facebook:master Mar 21, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@bvaughn bvaughn deleted the bvaughn:stable-Profiler branch Mar 21, 2019

@markerikson

This comment has been minimized.

Copy link

commented Mar 22, 2019

Per my comment on Twitter the other day, it would be nice to have metrics for commit times too (especially if sync setState updates are causing those to extend).

@kevinSuttle

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Awesome! Did this land in 16.8.5?

@bvaughn

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

No, 16.9 😄

@kevinSuttle

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Oh, nice. Good to know. Thanks!

Kiku-Reise added a commit to Kiku-Reise/react that referenced this pull request May 16, 2019

@gaearon gaearon referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.