Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 16.9 #16254

Merged
merged 3 commits into from Aug 8, 2019

Conversation

@gaearon
Copy link
Member

commented Jul 30, 2019

React

  • Add <React.Profiler> API for gathering performance measurements programmatically. (@bvaughn in #15172)
  • Remove unstable_ConcurrentMode in favor of unstable_createRoot. (@acdlite in #15532)

React DOM

React DOM Server

  • Fix incorrect output for camelCase custom CSS property names. (@bedakb in #16167)

React Test Utilities and Test Renderer

@sizebot

This comment has been minimized.

Copy link

commented Jul 30, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@seraj

This comment has been minimized.

Copy link

commented Jul 30, 2019

  • Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

Show resolved Hide resolved CHANGELOG.md Outdated
@Go7hic

This comment has been minimized.

Copy link

commented Aug 1, 2019

AsyncMode -> ConcurrentMode ->createRoot -> ?
When will it be stable

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@Go7hic When it's stable, you will see it in release notes. :-) We can't predict the future, but we're working to ship it. There's still more work ahead.

@radex

This comment has been minimized.

Copy link

commented Aug 2, 2019

Deprecate javascript: URLs as a common attack surface.

Is there something I can call to make javascript: urls an error, not a warning? Or does the feature flag require a special build of React to enable this?

EDIT: AFAICT not really — in react tests there’s:

const ReactFeatureFlags = require('shared/ReactFeatureFlags');
ReactFeatureFlags.disableJavaScriptURLs = true;

but i don’t think it will work in actual react builds.

I would be highly in favor of adding a function like import { disableJavascriptUrls } from react for this. Given how common and easy it is to have a huge XSS hole in links, I don’t think it’s appropriate to wait until React 17 when the feature is already there. A function with a recommendation to use it in the CHANGELOG (but still opt-in to preserve semver) seems like the best choice.

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

You can always do custom builds of React from master. (Even from the same commits that go out in a release.) And toggle it on. That's what we do. We generally don't allow runtime configuration because it doesn't compose well. Like if you have several apps on one page.

@lifeiscontent

This comment has been minimized.

Copy link

commented Aug 5, 2019

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

We've added initial infrastructure but haven't started on the implementation yet. Please let's keep this thread focused on the 16.9 release.

@Andarist

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

@6graNik

This comment has been minimized.

Copy link

commented Aug 6, 2019

  • Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

Don't forget who was the first mentioning this issue for core team, lol

https://twitter.com/6graNik/status/1060898694092988421

@BZ-koko

This comment has been minimized.

Copy link

commented Aug 6, 2019

Good Job

@threepointone

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

@Andarist this is a great usecase for async act. made a PR with a fix and some notes - final-form/react-final-form#578

@webmaster128 webmaster128 referenced this pull request Aug 6, 2019

Closed

Upgrade to react/react-dom ^16.9.0 once released #483

0 of 2 tasks complete
@mdrideout

This comment has been minimized.

Copy link

commented Aug 6, 2019

Is there anything significant new feature I should learn for this release? (Like hooks / suspense on previous releases)?

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

There will be a blog post, but this release is relatively minor in terms of new features.

@bvaughn

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

@gaearon: Did we intentionally omit mention of unstable_createSyncRoot ?

Jessidhia added a commit to Jessidhia/DefinitelyTyped that referenced this pull request Aug 7, 2019

@gaearon gaearon changed the title Changelog for 16.9 (TODO: add date) Changelog for 16.9 Aug 8, 2019

@gaearon gaearon referenced this pull request Aug 8, 2019

Merged

Blog post for 16.9 #2208

8 of 9 tasks complete

@acdlite acdlite merged commit 96cdf33 into master Aug 8, 2019

12 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details

Jessidhia added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.