Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 16.9 #16254

Merged
merged 3 commits into from Aug 8, 2019
Merged

Changelog for 16.9 #16254

merged 3 commits into from Aug 8, 2019

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Jul 30, 2019

React

  • Add <React.Profiler> API for gathering performance measurements programmatically. (@bvaughn in #15172)
  • Remove unstable_ConcurrentMode in favor of unstable_createRoot. (@acdlite in #15532)

React DOM

React DOM Server

  • Fix incorrect output for camelCase custom CSS property names. (@bedakb in #16167)

React Test Utilities and Test Renderer

@sizebot
Copy link

@sizebot sizebot commented Jul 30, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@seraj
Copy link

@seraj seraj commented Jul 30, 2019

  • Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

CHANGELOG.md Outdated Show resolved Hide resolved
@Go7hic
Copy link

@Go7hic Go7hic commented Aug 1, 2019

AsyncMode -> ConcurrentMode ->createRoot -> ?
When will it be stable

@gaearon
Copy link
Member Author

@gaearon gaearon commented Aug 2, 2019

@Go7hic When it's stable, you will see it in release notes. :-) We can't predict the future, but we're working to ship it. There's still more work ahead.

@radex
Copy link

@radex radex commented Aug 2, 2019

Deprecate javascript: URLs as a common attack surface.

Is there something I can call to make javascript: urls an error, not a warning? Or does the feature flag require a special build of React to enable this?

EDIT: AFAICT not really — in react tests there’s:

const ReactFeatureFlags = require('shared/ReactFeatureFlags');
ReactFeatureFlags.disableJavaScriptURLs = true;

but i don’t think it will work in actual react builds.

I would be highly in favor of adding a function like import { disableJavascriptUrls } from react for this. Given how common and easy it is to have a huge XSS hole in links, I don’t think it’s appropriate to wait until React 17 when the feature is already there. A function with a recommendation to use it in the CHANGELOG (but still opt-in to preserve semver) seems like the best choice.

@gaearon
Copy link
Member Author

@gaearon gaearon commented Aug 2, 2019

You can always do custom builds of React from master. (Even from the same commits that go out in a release.) And toggle it on. That's what we do. We generally don't allow runtime configuration because it doesn't compose well. Like if you have several apps on one page.

@lifeiscontent
Copy link

@lifeiscontent lifeiscontent commented Aug 5, 2019

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

@gaearon
Copy link
Member Author

@gaearon gaearon commented Aug 5, 2019

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

We've added initial infrastructure but haven't started on the implementation yet. Please let's keep this thread focused on the 16.9 release.

@Andarist
Copy link
Contributor

@Andarist Andarist commented Aug 5, 2019

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

@6graNik
Copy link

@6graNik 6graNik commented Aug 6, 2019

  • Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

Don't forget who was the first mentioning this issue for core team, lol

https://twitter.com/6graNik/status/1060898694092988421

@BZ-koko
Copy link

@BZ-koko BZ-koko commented Aug 6, 2019

Good Job

@threepointone
Copy link
Contributor

@threepointone threepointone commented Aug 6, 2019

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

@Andarist this is a great usecase for async act. made a PR with a fix and some notes - final-form/react-final-form#578

@mdrideout
Copy link

@mdrideout mdrideout commented Aug 6, 2019

Is there anything significant new feature I should learn for this release? (Like hooks / suspense on previous releases)?

@gaearon
Copy link
Member Author

@gaearon gaearon commented Aug 6, 2019

There will be a blog post, but this release is relatively minor in terms of new features.

@bvaughn
Copy link
Collaborator

@bvaughn bvaughn commented Aug 6, 2019

@gaearon: Did we intentionally omit mention of unstable_createSyncRoot ?

@gaearon gaearon changed the title Changelog for 16.9 (TODO: add date) Changelog for 16.9 Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet