Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maxDuration #15272

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Remove maxDuration #15272

merged 1 commit into from
Apr 2, 2019

Conversation

sebmarkbage
Copy link
Collaborator

We're going to replace it with a heuristic and different mechanism instead.

This PR just hard codes 150ms in place and fixes the tests. A follow up will refactor a bit more.

We instead assume a 150ms duration.
@ghengeveld
Copy link
Contributor

Could you explain what the heuristic and different mechanism will entail? I'm looking to integrate React Async with Suspense, but it seems to still be in flux. It's hard to work towards compatibility with a moving target.

@gaearon
Copy link
Collaborator

gaearon commented Mar 31, 2019

Agree it’s hard — which is why using Suspense for data fetching in Concurrent Mode is not marked as stable. If you’re doing it you’re kind of on your own. We’re still figuring out some things in the design.

@gaearon
Copy link
Collaborator

gaearon commented Mar 31, 2019

More on what’s stable and what isn’t:

https://reactjs.org/blog/2018/11/27/react-16-roadmap.html

) {
earliestTimeoutMs = timeoutPropMs;
}
const defaultSuspenseTimeout = 150;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a global const(config), why not lift it to the top?

@sebmarkbage sebmarkbage merged commit 4c75881 into facebook:master Apr 2, 2019
facebook-github-bot pushed a commit to facebook/flow that referenced this pull request Apr 5, 2019
Summary:
We're replacing this user-specific attribute with an internal heuristic.

Related PR facebook/react#15272

cc jbrown215
Pull Request resolved: #7613

Reviewed By: bvaughn

Differential Revision: D14784577

Pulled By: jbrown215

fbshipit-source-id: c93609a2f095c34fd85242798d4989abffb273a4
@gaearon gaearon mentioned this pull request Apr 20, 2019
63 tasks
@gaearon gaearon mentioned this pull request Mar 29, 2022
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Apr 15, 2024
This was referenced Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants