Remove maxDuration #15272
Merged
Remove maxDuration #15272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We instead assume a 150ms duration.
sebmarkbage
force-pushed
the
rmmaxduration
branch
from
5a3cc07
to
8ac7e4c
Compare
|
Could you explain what the heuristic and different mechanism will entail? I'm looking to integrate React Async with Suspense, but it seems to still be in flux. It's hard to work towards compatibility with a moving target. |
|
Agree it’s hard — which is why using Suspense for data fetching in Concurrent Mode is not marked as stable. If you’re doing it you’re kind of on your own. We’re still figuring out some things in the design. |
|
More on what’s stable and what isn’t: |
NE-SmallTown
reviewed
Apr 2, 2019
| ) { | ||
| earliestTimeoutMs = timeoutPropMs; | ||
| } | ||
| const defaultSuspenseTimeout = 150; |
There was a problem hiding this comment.
If it's a global const(config), why not lift it to the top?
acdlite
approved these changes
Apr 2, 2019
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Apr 5, 2019
Summary: We're replacing this user-specific attribute with an internal heuristic. Related PR facebook/react#15272 cc jbrown215 Pull Request resolved: #7613 Reviewed By: bvaughn Differential Revision: D14784577 Pulled By: jbrown215 fbshipit-source-id: c93609a2f095c34fd85242798d4989abffb273a4
facebook-github-bot
added
the
React Core Team
This was referenced May 19, 2024
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#651
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#655
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#659
Open
This was referenced Jun 12, 2024
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#720
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#724
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#728
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#732
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#734
Open
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#738
Open
This was referenced Jun 18, 2024
This was referenced Jun 18, 2024
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#742
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to replace it with a heuristic and different mechanism instead.
This PR just hard codes 150ms in place and fixes the tests. A follow up will refactor a bit more.