Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "maxDuration" documentation as the prop is removed from "<Suspense>" #22

Closed
dance2die opened this issue Jul 12, 2019 · 3 comments

Comments

@dance2die
Copy link
Contributor

dance2die commented Jul 12, 2019

maxDuration has been removed on 2 Apr 2019.

References:

  1. Removed from React: Remove maxDuration facebook/react#15272
  2. Removed from Flow: React React.Suspense maxDuration attribute facebook/flow#7613
@swyxio
Copy link
Owner

swyxio commented Jul 12, 2019

pr?

@dance2die
Copy link
Contributor Author

dance2die commented Jul 12, 2019

I will do it after work.

dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
…he date format to DD MMM YYYY to conform with the TimeLine dates. swyxio#22
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
dance2die added a commit to dance2die/fresh-concurrent-react that referenced this issue Jul 13, 2019
swyxio added a commit that referenced this issue Jul 14, 2019
Deprecate "maxDuration" documentation as the prop is removed from "<Suspense>" #22
NAKKA-K added a commit to bookbok/old-bookbok that referenced this issue Jun 9, 2020
@Dema
Copy link

Dema commented Dec 2, 2020

Is it possible to revert this change and restore maxDuration until you come up with better heuristics?. Because 150ms is too small and when we use lazy loading of React components we get the flickering of the loading indicators, just what we wanted to avoid by introducing Suspense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants