Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove <React.unstable_ConcurrentMode /> element type #15532
+118
−686
Conversation
acdlite
requested a review
from sebmarkbage
Apr 29, 2019
facebook-github-bot
added
the
CLA Signed
label
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
|
Could we preserve this(concurrent mode) and just allow it be used in root? By the way, could you share more info about why it's impossible to be used in a particular subtree without opting in the entire root? |
sebmarkbage
approved these changes
May 13, 2019
This comment has been minimized.
This comment has been minimized.
|
@NE-SmallTown It's not impossible, but it creates weird edge cases that we'd prefer not to support, given that we haven't found a compelling enough use case for it. |
acdlite
force-pushed the
acdlite:remove-concurrent-mode-element-type
branch
from
24c6edf
to
e34a55f
May 13, 2019
acdlite
merged commit 83fc258
into
facebook:master
May 13, 2019
1 check passed
ci/circleci
Your tests passed on CircleCI!
Details
Kiku-Reise
added a commit
to Kiku-Reise/react
that referenced
this pull request
May 16, 2019
Merged
This was referenced Aug 17, 2019
This was referenced Aug 19, 2019
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
acdlite commentedApr 29, 2019
•
edited
We decided to remove this because we're not convinced it's practical to opt a particular subtree into Concurrent Mode without opting in the entire root. The recommendation is to use
createRootinstead.