Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <React.unstable_ConcurrentMode /> element type #15532

Merged

Conversation

@acdlite
Copy link
Member

commented Apr 29, 2019

We decided to remove this because we're not convinced it's practical to opt a particular subtree into Concurrent Mode without opting in the entire root. The recommendation is to use createRoot instead.

@NE-SmallTown

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Could we preserve this(concurrent mode) and just allow it be used in root? By the way, could you share more info about why it's impossible to be used in a particular subtree without opting in the entire root?

@acdlite

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@NE-SmallTown It's not impossible, but it creates weird edge cases that we'd prefer not to support, given that we haven't found a compelling enough use case for it.

Remove <ConcurrentMode />
Use createSyncRoot instead.

@acdlite acdlite force-pushed the acdlite:remove-concurrent-mode-element-type branch from 24c6edf to e34a55f May 13, 2019

@acdlite acdlite merged commit 83fc258 into facebook:master May 13, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

Kiku-Reise added a commit to Kiku-Reise/react that referenced this pull request May 16, 2019

@gaearon gaearon referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.