Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <embed> not triggering onLoad #15614

Merged
merged 2 commits into from May 16, 2019

Conversation

@cherniavskii
Copy link
Contributor

commented May 10, 2019

Fixes #15613

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 10, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 10, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@philipp-spiess
Copy link
Collaborator

left a comment

Thank you for your PR @cherniavskii!

Implementation wise this looks solid to me. Do you mind adding a test as well? You can base it off this test case.

@cherniavskii

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@philipp-spiess sure, I'll update this PR later

@cherniavskii

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@philipp-spiess I've added a unit test, which fails without applying patch on this branch

@philipp-spiess
Copy link
Collaborator

left a comment

This looks great! Thank you.

I can merge later if nobody objects 🙂

@nhunzaker
Copy link
Collaborator

left a comment

Awesome. This looks good to me.

@philipp-spiess philipp-spiess merged commit 4bf88dd into facebook:master May 16, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@philipp-spiess

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

Thanks again 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.