Replace React.error and React.warn with getComponentStack

packages/react/src/React.js

@@ -51,7 +51,7 @@ import {
   jsxWithValidationDynamic,
 } from './ReactElementValidator';
 import ReactSharedInternals from './ReactSharedInternals';
-import {error, warn} from './withComponentStack';
+import getComponentStack from './getComponentStack';
 import createEvent from 'shared/createEventComponent';
 import {enableJSXTransformAPI, enableFlareAPI} from 'shared/ReactFeatureFlags';
 const React = {
@@ -72,8 +72,7 @@ const React = {
   lazy,
   memo,
 
-  error,
-  warn,
+  getComponentStack,
 
   useCallback,
   useContext,

packages/react/src/__tests__/getComponentStack-test.js

@@ -0,0 +1,125 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @emails react-core
+ */
+
+'use strict';
+
+function normalizeCodeLocInfo(str) {
+  return str && str.replace(/at .+?:\d+/g, 'at **');
+}
+
+describe('getComponentStack', () => {
+  let React = null;
+  let ReactTestRenderer = null;
+  let getComponentStack = null;
+
+  beforeEach(() => {
+    jest.resetModules();
+
+    React = require('react');
+    ReactTestRenderer = require('react-test-renderer');
+
+    getComponentStack = React.getComponentStack;
+  });
+
+  if (!__DEV__) {
+    it('does nothing in production mode', () => {
+      expect(getComponentStack()).toBe('');
+    });
+  }
+
+  if (__DEV__) {
+    it('returns an empty component stack when called outside of render', () => {
+      expect(getComponentStack()).toBe('');
+    });
+
+    it('includes component stack when called from a render method', () => {
+      class Parent extends React.Component {
+        render() {
+          return <Child />;
+        }
+      }
+
+      let capturedComponentStack = null;
+      function Child() {
+        capturedComponentStack = getComponentStack();
+        return null;
+      }
+
+      ReactTestRenderer.create(<Parent />);
+      expect(normalizeCodeLocInfo(capturedComponentStack)).toBe(
+        '\n    in Child (at **)' + '\n    in Parent (at **)',
+      );
+    });
+
+    it('returns component stack when called from a render phase lifecycle method', () => {
+      function Parent() {
+        return <Child />;
+      }
+
+      let capturedComponentStack = null;
+      class Child extends React.Component {
+        UNSAFE_componentWillMount() {
+          capturedComponentStack = getComponentStack();
+        }
+        render() {
+          return null;
+        }
+      }
+
+      ReactTestRenderer.create(<Parent />);
+      expect(normalizeCodeLocInfo(capturedComponentStack)).toBe(
+        '\n    in Child (at **)' + '\n    in Parent (at **)',
+      );
+    });
+
+    it('returns component stack when called from a commit phase lifecycle method', () => {
+      function Parent() {
+        return <Child />;
+      }
+
+      let capturedComponentStack = null;
+      class Child extends React.Component {
+        componentDidMount() {
+          capturedComponentStack = getComponentStack();
+        }
+        render() {
+          return null;
+        }
+      }
+
+      ReactTestRenderer.create(<Parent />);
+      expect(normalizeCodeLocInfo(capturedComponentStack)).toBe(
+        '\n    in Child (at **)' + '\n    in Parent (at **)',
+      );
+    });
+
+    it('returns component stack when called from a passive effect handler', () => {
+      class Parent extends React.Component {
+        render() {
+          return <Child />;
+        }
+      }
+
+      let capturedComponentStack = null;
+      function Child() {
+        React.useEffect(() => {
+          capturedComponentStack = getComponentStack();
+        });
+        return null;
+      }
+
+      ReactTestRenderer.act(() => {
+        ReactTestRenderer.create(<Parent />);
+      });
+      expect(normalizeCodeLocInfo(capturedComponentStack)).toBe(
+        '\n    in Child (at **)' + '\n    in Parent (at **)',
+      );
+    });
+  }
+});

packages/react/src/getComponentStack.js

@@ -0,0 +1,22 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import ReactSharedInternals from 'shared/ReactSharedInternals';
+
+let getComponentStack = function() {
+  return '';
+};
+
+if (__DEV__) {
+  const ReactDebugCurrentFrame = ReactSharedInternals.ReactDebugCurrentFrame;
+
+  getComponentStack = function() {
+    return ReactDebugCurrentFrame.getStackAddendum();
+  };
+}
+
+export default getComponentStack;