Add tail="hidden" option to SuspenseList #16024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: 29b4559...6ec55cb react-art
react-dom
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
sebmarkbage
commented
Jul 1, 2019
sebmarkbage
commented
Jul 1, 2019
|
SSR is pretty tricky with this approach, since we won't have DOM nodes for all the items in the list during reconciliation. If we assume that we have the same number of items in the list and that we suspend at at least the same places as the server, then at least the collapsed mode works out. Because we'll at most render the last tail item which will be in fallback state on the server and get replaced on the client. However, with "hidden" mode, we don't know that we've hit the end of the list yet. We need to render it first and when we try to do that, we get a hydration error because that node was deleted. If they were actually just hidden we could potentially start hydrating them. |
sebmarkbage
force-pushed
the
suspensehidden
branch
2 times, most recently
from
4c8d987
to
8039935
Compare
sebmarkbage
force-pushed
the
suspensehidden
branch
from
d52bc4b
to
8654058
Compare
sebmarkbage
changed the title
This lets us reuse the found fallback so we can transfer the update queue from it.
sebmarkbage
force-pushed
the
suspensehidden
branch
from
8654058
to
de7e82b
Compare
This function exists to optimize the case where all the boundaries in the head are already suspended. In that case there's no need to do a second rerender pass. However, in that case, we're not really going to show much new content on the screen anyway. So I'm not sure it's worth keeping this special case around. scan every row
sebmarkbage
force-pushed
the
suspensehidden
branch
from
de7e82b
to
6ec55cb
Compare
|
I think this is ready for review and landing now. I ended up needing to do a lot of factoring to make it nicer and found a number of bugs along the way. Particularly, to minimize file size I ended up removing one optimization which causes extra rerenders. 6ec55cb I'm not sure this is the right call but maybe with resuming this won't matter much. I'll address the SSR case in a follow up. |
acdlite
approved these changes
Jul 12, 2019
| hasSuspendedChildrenAndNewContent(workInProgress, renderedTail); | ||
| let newThennables = suspended.updateQueue; | ||
| if (newThennables !== null) { | ||
| workInProgress.updateQueue = newThennables; |
There was a problem hiding this comment.
Is this approach something we'll want to rethink later? By always attaching thenables to the SuspenseList instead of the inner boundary, perhaps.
There was a problem hiding this comment.
We could possibly do that in throwException, yea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #16007.
This is similar to
tail="collapsed"except it hides all rows in the tail. The added complexity here is that sometimes we only know that we've hit the tail after we've already rendered this row. So we need undo the effects added by rendering the row.Additionally, by not committing the boundary, there's nothing to retry. So we need to transfer the promise set to the list so that we get a retry if the only thing to ping was in the tail.