Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tail="hidden" option to SuspenseList #16024

Merged
merged 5 commits into from
Jul 12, 2019
Merged

Add tail="hidden" option to SuspenseList #16024

merged 5 commits into from
Jul 12, 2019

Commits on Jul 12, 2019

  1. Move misaligned comment

    @sebmarkbage
    sebmarkbage committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    d3388a5 View commit details
    Browse the repository at this point in the history

  2. Add tail="hidden" option

    @sebmarkbage
    sebmarkbage committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    8200936 View commit details
    Browse the repository at this point in the history

  3. isShowingAnyFallbacks -> findFirstSuspended 

    This lets us reuse the found fallback so we can transfer the update queue
from it.
    @sebmarkbage
    sebmarkbage committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    73d6c0b View commit details
    Browse the repository at this point in the history

  4. We can't reset Placement tags or we'll forget to insert them

    @sebmarkbage
    sebmarkbage committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    2a052b4 View commit details
    Browse the repository at this point in the history

  5. Delete hasSuspendedChildrenAndNewContent optimization 

    This function exists to optimize the case where all the boundaries in the
head are already suspended. In that case there's no need to do a second
rerender pass. However, in that case, we're not really going to show much
new content on the screen anyway.

So I'm not sure it's worth keeping this special case around.

scan every row
    @sebmarkbage
    sebmarkbage committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    6ec55cb View commit details
    Browse the repository at this point in the history