-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't hyphenate custom CSS properties for ReactDOMServer #16167
Conversation
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Please add a test to one of |
@gaearon updated. |
@@ -212,7 +212,8 @@ const processStyleName = function(styleName) { | |||
if (styleNameCache.hasOwnProperty(styleName)) { | |||
return styleNameCache[styleName]; | |||
} | |||
const result = hyphenateStyleName(styleName); | |||
const isCustomProperty = styleName.indexOf('--') === 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not ideal that we do this check again because createMarkupForStyles
which calls us already does the same check anyway.
Looks good to me. Thanks. |
This PR fixes #16160