Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hyphenate custom CSS properties for ReactDOMServer #16167

Merged
merged 8 commits into from Jul 26, 2019

Conversation

@bedakb
Copy link
Contributor

commented Jul 20, 2019

This PR fixes #16160

@bedakb bedakb changed the title Don't hyphenate custom CSS properties Don't hyphenate custom CSS properties for ReactDOMServer Jul 20, 2019

@sizebot

This comment has been minimized.

Copy link

commented Jul 20, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@gaearon

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Please add a test to one of ReactDOMServerIntegration files. This will likely uncover that we still emit an incorrect warning. To fix the warning I think you'll need to make a similar fix here.

@bedakb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

@gaearon updated.
Hope It looks ok.

@@ -212,7 +212,8 @@ const processStyleName = function(styleName) {
if (styleNameCache.hasOwnProperty(styleName)) {
return styleNameCache[styleName];
}
const result = hyphenateStyleName(styleName);
const isCustomProperty = styleName.indexOf('--') === 0;

This comment has been minimized.

Copy link
@gaearon

gaearon Jul 26, 2019

Member

It's not ideal that we do this check again because createMarkupForStyles which calls us already does the same check anyway.

gaearon added some commits Jul 26, 2019

@gaearon gaearon merged commit 858c842 into facebook:master Jul 26, 2019

12 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
@gaearon

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Looks good to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.