[react-ui] Move experimental event+a11y work to react-ui package #16794
Conversation
trueadm
requested review from
threepointone,
bvaughn,
necolas,
gaearon and
acdlite
Details of bundled changes.Comparing: 9691eb2...ace6a73 react-ui
|
|
@bvaughn We might decide to move this to the React package in the future, but for now this is all more of a package of experimental work we're playing around with internally. I do quite like |
|
|
||
| import React from 'react'; | ||
| import {tabFocusableImpl} from './TabbableScope'; | ||
| import {useKeyboard} from 'react-events/keyboard'; | ||
| import {useKeyboard} from '../../events/keyboard'; |
There was a problem hiding this comment.
Oops this is the non-type import that could get inlined
There was a problem hiding this comment.
This is okay. I plan on doing a follow up where I add the a11y components to build and will revise it there.
|
|
||
| import React from 'react'; | ||
| import {TabbableScope} from './TabbableScope'; | ||
| import {useKeyboard} from 'react-events/keyboard'; | ||
| import {useKeyboard} from '../../events/keyboard'; |
There was a problem hiding this comment.
This is okay. I plan on doing a follow up where I add the a11y components to build and will revise it there.
|
I think this PR may have broken DevTools tests. Can you run Hm... I think CI runs this though so maybe my local Yarn is just corrupted.
|
|
I had a similar issue when deleting the "react-events" directory locally. Git doesn't register directory removals as a change, so maybe we should update the script to check if the directory is empty? |
This PR renamed the
react-eventspackage toreact-uiand adds a top-level directory for each category. Thereact-eventswork goes into a top-leveleventsdirectory, whilst all the accessibility component experiments go intoaccessibility. This also allows us to move relevant other parts of our experimental UI work into React Interactions, and other projects, into other top-level directories ofreact-uiwithout having to make them fit into existing directory structures (which is getting awkward).